Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plugin methods to manage the lifecycle of service templates #2226

Open
7 tasks
swaroopar opened this issue Dec 19, 2024 · 1 comment
Open
7 tasks

add plugin methods to manage the lifecycle of service templates #2226

swaroopar opened this issue Dec 19, 2024 · 1 comment
Labels
Accepted Issues that have been accepted and planned enhancement New feature or request

Comments

@swaroopar
Copy link
Contributor

swaroopar commented Dec 19, 2024

When service templates are registered or updated, we must allow CSP plugins to automate checks wherever necessary.

Method - validateServiceTemplate

  • Add interface method -> validateServiceTemplate -> Returns an enum -> APPROVED, MANUAL_REVIEW_REQUIRED, REJECTED
  • 'auto-approve' flag validation must move to the corresponding plugin method.
  • 'MANUAL_REVIEW_REQUIRED' means the CSP must then review it once manually.
  • The default implementation for now can be -> if auto-approve is true, return APPROVED; otherwise return MANUAL_REVIEW_REQUIRED.

Method - prepareServiceTemplate

  • Add interface method -> prepareServiceTemplate -> returns void. This method will then run necessary preparation steps in the CSP's infrastructure (Eg., configure API GW, configure IAM, etc)
  • When the validateServiceTemplate returns APPROVED or the CSP's review method approve's the service, then call the prepareServiceTemplate in the corresponding plugin.
  • Default implementation just returns.
@swaroopar swaroopar added enhancement New feature or request Accepted Issues that have been accepted and planned labels Dec 19, 2024
@swaroopar swaroopar added this to the Sprint 122024_2 milestone Dec 19, 2024
@baixinsui
Copy link
Contributor

I will take it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Issues that have been accepted and planned enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants