Changes to ISV view in UI to show current status of the service template #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
WangLiNaruto
force-pushed
the
feature/current_service_status
branch
from
911402f to
891b743
Compare
baixinsui
reviewed
Dec 9, 2024
WangLiNaruto
force-pushed
the
feature/current_service_status
branch
2 times, most recently
from
d249e7f to
ce97006
Compare
swaroopar
requested changes
Dec 9, 2024
src/components/content/catalog/services/update/UpdateService.tsx
Outdated
Show resolved
Hide resolved
src/components/content/catalog/services/update/UpdateService.tsx
Outdated
Show resolved
Hide resolved
src/components/content/catalog/services/update/UpdateService.tsx
Outdated
Show resolved
Hide resolved
src/components/content/catalog/services/update/UpdateService.tsx
Outdated
Show resolved
Hide resolved
WangLiNaruto
force-pushed
the
feature/current_service_status
branch
from
2875af7 to
c177518
Compare
WangLiNaruto
force-pushed
the
feature/current_service_status
branch
from
c177518 to
1155580
Compare
swaroopar
requested changes
Dec 10, 2024
| {(activeServiceDetail.serviceTemplateRegistrationState === 'in-review' || | ||
| activeServiceDetail.serviceTemplateRegistrationState === 'approved') && | ||
| !activeServiceDetail.availableInCatalog ? ( | ||
| <Badge.Ribbon |
There was a problem hiding this comment.
still the display is wrong when update review is in progress and the original template is still available in catalog. I see only 'review in progress'.
And more over, re-register button is enabled in this case. Which is also wrong.
WangLiNaruto
force-pushed
the
feature/current_service_status
branch
from
d76011e to
1155580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed eclipse-xpanse/xpanse#2110
Register success:
Audit:
Delete:
Unregister:
Reregister:
Update:
