Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing: more eventbus and HTTP tags #67

Closed
Olamshin opened this issue Nov 29, 2023 · 5 comments
Closed

Tracing: more eventbus and HTTP tags #67

Olamshin opened this issue Nov 29, 2023 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Olamshin
Copy link

Version

4.4.6

Context

According to the document here, the following span attribute should be present for HTTP server spans.

  • http.scheme
  • http.target
  • net.host.name
  • net.host.port

Absence of these attributes would mean OTel spans from vert.x may not be categorized as HTTP spans by a telemetry backend.

@Olamshin Olamshin added the bug Something isn't working label Nov 29, 2023
@tsegismont tsegismont self-assigned this Nov 30, 2023
@tsegismont tsegismont added this to the 4.5.1 milestone Nov 30, 2023
@tsegismont
Copy link
Contributor

Thanks for the report, @Olamshin

Would you like to contribute the fix?

@Olamshin
Copy link
Author

Olamshin commented Dec 1, 2023

@tsegismont Yes, i can attempt this. Looks like the core changes would here? Any other tips would be appreciated!

@tsegismont
Copy link
Contributor

@tsegismont Yes, i can attempt this. Looks like the core changes would here? Any other tips would be appreciated!

Yes, I would start here. Then we need to make sure we don't break other tracing implementations

@vietj
Copy link
Member

vietj commented Dec 8, 2023

we should keep the actual names and translate them in vertx open tracing when it get the tags. if there are missing tags then we should add them using the same convention

@tsegismont tsegismont changed the title OpenTelemetry Semantic Convention for HTTP Server Spans Missing span attributes for HTTP Server Spans Dec 8, 2023
@tsegismont tsegismont changed the title Missing span attributes for HTTP Server Spans Tracing: more eventbus and HTTP tags Dec 8, 2023
@tsegismont
Copy link
Contributor

Resolved by eclipse-vertx/vert.x#5024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants