-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing: more eventbus and HTTP tags #67
Comments
Thanks for the report, @Olamshin Would you like to contribute the fix? |
@tsegismont Yes, i can attempt this. Looks like the core changes would here? Any other tips would be appreciated! |
Yes, I would start here. Then we need to make sure we don't break other tracing implementations |
we should keep the actual names and translate them in vertx open tracing when it get the tags. if there are missing tags then we should add them using the same convention |
Resolved by eclipse-vertx/vert.x#5024 |
Version
4.4.6
Context
According to the document here, the following span attribute should be present for HTTP server spans.
Absence of these attributes would mean OTel spans from vert.x may not be categorized as HTTP spans by a telemetry backend.
The text was updated successfully, but these errors were encountered: