Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to configure Row for returning booleans instead of Byte in MySQL reactive client #1366

Open
olofumark opened this issue Oct 13, 2023 · 2 comments
Milestone

Comments

@olofumark
Copy link

Describe the feature

io.vertx.sqlclient.Row needs a way to specify preference for the retrieval of all boolean columns as booleans instead of Byte.

Currently all boolean columns are served as Byte unless you explicitly call getBoolean() for individual fields.

Use cases

  1. Reading data and streaming without having to do extra conversions.
  2. Consistency with query expectations e.g after doing SELECT * FROM ... WHERE sent = true; only to be served the Byte equivalent of the boolean fields which(though might be the low level storage format) is not very helpful unless first converted.
  3. Very helpful for migrating from the legacy JDBC client if you already have frontend systems relying on true and false where they will break if suddenly served with 0's and 1's.
@tsegismont
Copy link
Contributor

Thanks for reporting @olofumark

Thoughts @BillyYccc ?

@tsegismont tsegismont added this to the 4.5.0 milestone Oct 13, 2023
@BillyYccc
Copy link
Member

I was aware of mysql jdbc providing a dedicated transformation option, I wonder maybe we could instead pick up and support the custom data type codec to cover such use cases.

@vietj vietj modified the milestones: 4.5.0, 4.5.1 Nov 15, 2023
@vietj vietj modified the milestones: 4.5.1, 4.5.2 Dec 13, 2023
@vietj vietj modified the milestones: 4.5.2, 4.5.3 Jan 30, 2024
@vietj vietj modified the milestones: 4.5.3, 4.5.4 Feb 6, 2024
@vietj vietj modified the milestones: 4.5.4, 4.5.5 Feb 22, 2024
@vietj vietj modified the milestones: 4.5.5, 4.5.6 Mar 14, 2024
@vietj vietj modified the milestones: 4.5.6, 4.5.7, 4.5.8 Mar 21, 2024
@vietj vietj modified the milestones: 4.5.8, 4.5.9 May 24, 2024
@vietj vietj modified the milestones: 4.5.9, 4.5.10 Jul 17, 2024
@vietj vietj modified the milestones: 4.5.10, 4.5.11 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants