Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TxPostgresqlLocalInstance #638

Closed
wolf4ood opened this issue Jul 20, 2023 · 0 comments · Fixed by #732
Closed

Remove TxPostgresqlLocalInstance #638

wolf4ood opened this issue Jul 20, 2023 · 0 comments · Fixed by #732
Assignees
@wolf4ood
Labels
enhancement New feature or request refactoring Refactoring, does not add functionality

Comments

@wolf4ood
Copy link
Contributor

Describe the solution you'd like

We should remove the class TxPostgresqlLocalInstance which is copy and paste of EDC upstream PostgresqlLocalInstance when we upgrade to the next EDC version.

This was due the introduction of `test-containers in #620 which required a flexible way of creating databases with different connections parameters
@wolf4ood wolf4ood added the enhancement New feature or request label Jul 20, 2023
@wolf4ood wolf4ood self-assigned this Jul 20, 2023
@wolf4ood wolf4ood added the refactoring Refactoring, does not add functionality label Jul 20, 2023
@wolf4ood wolf4ood mentioned this issue Aug 24, 2023
Merged
@github-project-automation github-project-automation bot moved this from Open to Done in EDC Board Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolf4ood wolf4ood

Labels
enhancement New feature or request refactoring Refactoring, does not add functionality
Projects
EDC Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(tests): removes TxPostgresqlLocalInstance wolf4ood/tractusx-edc
1 participant
@wolf4ood