Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate code coverage #389

Closed
wolf4ood opened this issue May 19, 2023 · 3 comments · Fixed by #533
Closed

Integrate code coverage #389

wolf4ood opened this issue May 19, 2023 · 3 comments · Fixed by #533
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wolf4ood
Copy link
Contributor

wolf4ood commented May 19, 2023

Describe the solution you'd like

It would be cool to integrate a coverage tool in the repository and in the PRs workflow

We should have in the main README a pointer in the current coverage status and we
integrate a tool that calculate the impact in coverage diff in PR.

Describe the solution you'd like

In upstream EDC the combination of Jacoco + Codecov it's used. Probably make sense to use the same
setup

@wolf4ood wolf4ood added the enhancement New feature or request label May 19, 2023
@wolf4ood wolf4ood added the good first issue Good for newcomers label May 19, 2023
@paullatzelsperger
Copy link
Contributor

Tractus-X uses SonarCloud to evaluate coverage, and we already have Jacoco. Could be that the merged jacoco report is somehow incomplete, or doesn't get created, which should be investigated.

@paullatzelsperger
Copy link
Contributor

paullatzelsperger commented Jun 26, 2023

I'll re-open this, because according to the documentation, the automatic analysis does not support Code Coverage.
We therefor have to switch back to CI-triggered analysis. I'll open another PR for that. This will, however, only enable Sonar analysis on commits in upstream, no PRs.

Since all our test jobs are spread across multiple jobs (for parallelization), we'll need to collect all the test results (upload/download artefacts), generate the aggregate report and then upload them to sonar. It's questionable whether that is worth the effort.

@paullatzelsperger
Copy link
Contributor

paullatzelsperger commented Jul 19, 2023

to reiterate: we either have automatic Sonar analysis on every commit, but we'll have no coverage analysis, or we perform the analysis manually, but only on upstream commits.

Alternatively, we could introduce another tool just for coverage but that seems a bit over-the-top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants