Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misspelled gradlew commands in the documents #302

Closed
sekikn opened this issue May 1, 2023 · 3 comments · Fixed by #315
Closed

Fix misspelled gradlew commands in the documents #302

sekikn opened this issue May 1, 2023 · 3 comments · Fixed by #315
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@sekikn
Copy link
Contributor

sekikn commented May 1, 2023

Describe the bug

There are some misspelled gradlew commands in the documents. It would be better to fix them so that users can copy-and-paste the command as it is.

$ git grep gardlew
docs/kit/operation-view/page03_local_setup_controlplane.md:./gardlew :edc-controlplane:edc-controlplane-postgresql-hashicorp-vault:dockerize
docs/kit/operation-view/page04_local_setup_dataplane.md:./gardlew :edc-dataplane:edc-dataplane-hashicorp-vault:dockerize
edc-controlplane/edc-controlplane-postgresql-hashicorp-vault/README.md:./gardlew :edc-controlplane:edc-controlplane-postgresql-hashicorp-vault:dockerize
edc-controlplane/edc-controlplane-postgresql/README.md:./gardlew :edc-controlplane:edc-controlplane-postgresql:dockerize
edc-dataplane/edc-dataplane-azure-vault/README.md:./gardlew :edc-dataplane:edc-dataplane-azure-vault:dockerize
edc-dataplane/edc-dataplane-base/README.md:./gardlew :edc-dataplane:edc-dataplane-base:build
edc-dataplane/edc-dataplane-hashicorp-vault/README.md:./gardlew :edc-dataplane:edc-dataplane-hashicorp-vault:dockerize
@sekikn sekikn added the bug Something isn't working label May 1, 2023
@sekikn
Copy link
Contributor Author

sekikn commented May 1, 2023

Hi Tractus-X team,

Recently I'm interested in Tractus-X and trying to run it locally. During that trial, I found some minor issues mainly in its documentation. I'd be glad if I could contribute PRs for them.

@florianrusch-zf
Copy link
Contributor

Hey, we are happy about every contribution 😉 Please allow me to make a quick reference to our https://github.com/eclipse-tractusx/tractusx-edc/blob/main/pr_etiquette.md regarding providing PRs.

Regarding this issue: thanks a lot for your discoveries! If you want, you can create a PR for it. This would be a "good first issue".

@florianrusch-zf florianrusch-zf added the good first issue Good for newcomers label May 3, 2023
@sekikn
Copy link
Contributor Author

sekikn commented May 8, 2023

Thanks for the reply! I'll confirm the PR etiquette and submit a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants