Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STS DIM Url should be optional property in helm chart #1443

Closed
hemantxpatel opened this issue Jul 23, 2024 · 1 comment · Fixed by #1444
Closed

STS DIM Url should be optional property in helm chart #1443

hemantxpatel opened this issue Jul 23, 2024 · 1 comment · Fixed by #1444
Assignees
Labels
bug Something isn't working

Comments

@hemantxpatel
Copy link

Describe the bug

TractusX EDC allows to use either STS DIM Client or STS Remote client based on whether config tx.edc.iam.sts.dim.url is defined or not.
Chart makes it as a required property so it's not possible to use STS Remote client.

A clear and concise description of what the bug is.

- name: "TX_EDC_IAM_STS_DIM_URL"
value: {{ .Values.iatp.sts.dim.url | required ".Values.iatp.sts.dim.url is required" | quote}}

To Reproduce

Steps to reproduce the behavior:

Try to deploy tractusx-edc via helm chart with dim url as null.

repository = "https://eclipse-tractusx.github.io/charts/dev"
chart      = "tractusx-connector"
version    = "0.8.0-rc1"

Error:

 Error: execution error at (tractusx-connector/templates/deployment-dataplane.yaml:219:51): .Values.iatp.sts.dim.url is required
│
│   with module.bob-connector.helm_release.connector,
│   on modules\connector\main.tf line 27, in resource "helm_release" "connector":
│   27: resource "helm_release" "connector" {

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots/Error Messages

If applicable, add screenshots and/or error messages to help explain your problem.

Context Information

Add any other context or information about the problem here.

  • Used version: [e.g. Commit Hash]
  • OS: [e.g. Mac OS (M1), Windows, Linux]
  • Docker Version: [e.g. 20.10.12]
  • java --version:

Possible Implementation

You already know the root cause of the erroneous state and how to fix it? Feel free to share your thoughts.

@hemantxpatel hemantxpatel added bug Something isn't working triage all new issues awaiting classification labels Jul 23, 2024
@paullatzelsperger paullatzelsperger self-assigned this Jul 23, 2024
@paullatzelsperger paullatzelsperger removed the triage all new issues awaiting classification label Jul 23, 2024
@hemantxpatel
Copy link
Author

Few other references in dataplane files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants