-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change QualityNotificationResponse to include a list of QualityNotificationMessage #423
Closed
3 tasks done
ds-ashanmugavel opened this issue
Dec 20, 2023
· 2 comments
· Fixed by catenax-ng/tx-traceability-foss#1042, catenax-ng/tx-traceability-foss#1044, catenax-ng/tx-traceability-foss#1052, catenax-ng/tx-traceability-foss#1074 or catenax-ng/tx-traceability-foss#1077
Closed
3 tasks done
Change QualityNotificationResponse to include a list of QualityNotificationMessage #423
ds-ashanmugavel opened this issue
Dec 20, 2023
· 2 comments
· Fixed by catenax-ng/tx-traceability-foss#1042, catenax-ng/tx-traceability-foss#1044, catenax-ng/tx-traceability-foss#1052, catenax-ng/tx-traceability-foss#1074 or catenax-ng/tx-traceability-foss#1077
Labels
backend
Backend related issues
Comments
jzbmw
changed the title
⭐[BE] Change QualityNotificationResponse to include a list of QualityNotificationMessage
Change QualityNotificationResponse to include a list of QualityNotificationMessage
Jan 9, 2024
This was referenced Feb 1, 2024
6 tasks
2 tasks
Merged
Ready for retest after feedback. @ds-crehm |
Successfully tested on E2E-A and E2E-B. Ready for review @jzbmw |
17 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a User
I want to see the status of my sent/received QualityNotificationMessages
so that I have a detailed overview of the success/error messages
Links
Hints / Details
The QualityNotificationResponse class could be extended like the following:
private String errorMessage;The QualityNotificationMessages are already persistent on the database level. So there's only an additional mapping to the response model necessary.
One thing to keep in mind is that the errorMessage field has to be moved to the new QualityNotificationMessageResponse class. The error message should be shown on the message level and not on the parent-notification level. The errorMessage field is currently always null. However, FE reads this attribute in the reponse of the BE
Acceptance Criteria
Out of Scope
The text was updated successfully, but these errors were encountered: