Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change QualityNotificationResponse to include a list of QualityNotificationMessage #423

Assignees
Labels
backend Backend related issues

Comments

@ds-ashanmugavel
Copy link
Contributor

ds-ashanmugavel commented Dec 20, 2023

As a User
I want to see the status of my sent/received QualityNotificationMessages
so that I have a detailed overview of the success/error messages

Links

Hints / Details

The QualityNotificationResponse class could be extended like the following:

As Is To Be
private Long id; private Long id;
private QualityNotificationStatusResponse status; private QualityNotificationStatusResponse status;
private String description; private String description;
private String createdBy; private String createdBy;
private String createdByName; private String createdByName;
private String createdDate; private String createdDate;
private List assetIds; private List assetIds;
private QualityNotificationSideResponse channel; private QualityNotificationSideResponse channel;
private QualityNotificationReasonResponse reason; private QualityNotificationReasonResponse reason;
private String sendTo; private String sendTo;
private String sendToName; private String sendToName;
private QualityNotificationSeverityResponse severity; private QualityNotificationSeverityResponse severity;
private String targetDate; private String targetDate;
private String errorMessage; private String errorMessage;
//new:
private List qualityNotificationMessages;

The QualityNotificationMessages are already persistent on the database level. So there's only an additional mapping to the response model necessary.

One thing to keep in mind is that the errorMessage field has to be moved to the new QualityNotificationMessageResponse class. The error message should be shown on the message level and not on the parent-notification level. The errorMessage field is currently always null. However, FE reads this attribute in the reponse of the BE

Acceptance Criteria

Out of Scope

  • Placing a value in errorMessage is out of scope for this story
@github-project-automation github-project-automation bot moved this to inbox in Trace-X Dec 20, 2023
@jzbmw jzbmw moved this from inbox to backlog in Trace-X Jan 8, 2024
@jzbmw jzbmw added the backend Backend related issues label Jan 9, 2024
@jzbmw jzbmw changed the title ⭐[BE] Change QualityNotificationResponse to include a list of QualityNotificationMessage Change QualityNotificationResponse to include a list of QualityNotificationMessage Jan 9, 2024
@mkanal mkanal moved this from backlog to next in Trace-X Mar 5, 2024
@ds-mwesener ds-mwesener moved this from next to wip in Trace-X Mar 7, 2024
@ds-mwesener ds-mwesener self-assigned this Mar 7, 2024
@ds-mwesener ds-mwesener moved this from wip to review in Trace-X Mar 7, 2024
@ds-mwesener ds-mwesener moved this from review to wip in Trace-X Mar 13, 2024
@ds-mwesener ds-mwesener moved this from wip to test in Trace-X Mar 14, 2024
@ds-mwesener
Copy link
Contributor

Ready for retest after feedback. @ds-crehm

@ds-crehm
Copy link
Contributor

Successfully tested on E2E-A and E2E-B. Ready for review @jzbmw

@ds-crehm ds-crehm moved this from test to review in Trace-X Mar 15, 2024
@ds-crehm ds-crehm assigned jzbmw and unassigned ds-crehm Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment