-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add initial implementation for DIM wallet stub #2
feat: add initial implementation for DIM wallet stub #2
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | - | Generic High Entropy Secret | 0907bfe | src/main/java/org/eclipse/tractusx/wallet/stub/apidoc/TokenApiDoc.java | View secret |
- | - | Generic High Entropy Secret | 0907bfe | docs/api/openAPI.json | View secret |
- | - | Generic High Entropy Secret | 0907bfe | src/main/java/org/eclipse/tractusx/wallet/stub/apidoc/EDCStubApiDoc.java | View secret |
- | - | Generic High Entropy Secret | 0907bfe | docs/api/openAPI.json | View secret |
- | - | Generic High Entropy Secret | 0907bfe | docs/api/openAPI.json | View secret |
- | - | Generic High Entropy Secret | 0907bfe | src/main/java/org/eclipse/tractusx/wallet/stub/apidoc/CredentialsApiDoc.java | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
All secret alerts are false positives. These values are used as a sample request in API doc |
IP review ticket created: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15838 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, just some notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please make sure that your pr title aligns better with conventional commit messages? for instance feat: add initial implementation for DIM wallet stub
Also, please take care of the GitGuardian findings: you mentioned that they were false positives, with you committer rights you are enabled to mark them accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed that the following lib is still marked as restricted in the DEPENDENCIES file:
maven/mavencentral/org.wiremock/wiremock-standalone/3.9.1, (Apache-2.0 AND EPL-2.0) OR (Apache-2.0 AND GPL-2.0-only AND NOASSERTION), restricted, clearlydefined
Did you create an IP issue? If so, could you link it?
I think you should only open the IP issue for the project content / initial contribution once also the all 3rd party libs are vetted.
@nitin-vavdiya I'm providing already some information for the review of the project content, which should only be started once you're sure that this PR remains as is / unchanged, so only once #2 (review) is solved. Relevant section in the Eclipse Foundation Handbook: https://www.eclipse.org/projects/handbook/#ip-project-content As this PR represents the initial contribution and contains changes which were authored - not just by you (committer) but -also by contributors (see Authors), it needs to undergo a review of Project Content at the Eclipse Foundation, for which you (as committer) need to open an issue in Gitlab using the the according issue template, see https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/wikis/Requesting-a-Review. Besides the Here an example of a recent review of Project content, merely as example https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15836. |
Thanks for pointing this out. I already create IP check for the restricted lib: IP issue I closed this IP check issue for WireMock. Now there is no any restricted lib in the code. |
PR title changed I cannot see this repository in the GitGuardian app. maybe someone needs to give access. |
Thank you for the information. IP check ticket is created: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15838 |
As a source code ZIP file is uploaded in IP check, |
@nitin-vavdiya I'd find it odd if you couldn't manage the secret findings by GitGuardian with your committer rights.. don't you have the option to |
Done, I was looking for resolve issue like button, so it will not rise the same issue again (Same as sonarQube maybe) |
I'm dismissing the review as I'm heading to vacation for a couple of weeks. Feel free to merge the PR once the IP review has been approved: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15838
Merging this PR based on this comment |
Description
Initial contribution for SSI DIM wallet stub application
Why
Issue Link
Refs: 788
Checklist
Please delete options that are not relevant.
I have followed the contributing guidelines
I have performed IP checks for added or updated 3rd party libraries
I have added copyright and license headers, footers (for .md files) or files (for images) //open source requirement
I have performed a self-review of my own code
I have successfully tested my changes locally
I have added tests and updated existing tests that prove my changes work
I have checked that new and existing tests pass locally with my changes
I have commented my code, particularly in hard-to-understand areas