Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model Issue]: Serial Part 3.0.0 #723

Open
catroest opened this issue Apr 29, 2024 · 8 comments
Open

[Model Issue]: Serial Part 3.0.0 #723

catroest opened this issue Apr 29, 2024 · 8 comments

Comments

@catroest
Copy link
Contributor

catroest commented Apr 29, 2024

URL to Model with Issue

https://github.com/eclipse-tractusx/sldt-semantic-models/tree/main/io.catenax.serial_part/3.0.0

Issue Description

Date regex does not fit the example value.
Schema is not valid to payload!

image

@catroest
Copy link
Contributor Author

@johannsvarela

@johannsvarela
Copy link
Contributor

@catroest means we must change the String example and therefore we have to provide a new SerialPart version (i guess 3.0.1 or 3.1.0)?

FYI @BenediktMuellerIML

@jSchuetz88
Copy link
Member

jSchuetz88 commented Nov 11, 2024

@eckardg As this is a part of the Industry Core, could you check?

Edit: I will check in parallel, whether this is wrongly generated by the SAMM-Modelling tool.

@johannsvarela
Copy link
Contributor

johannsvarela commented Nov 12, 2024

@eckardg There are currently two issues that need to be resolved:

  1. The example for the date information does not match the defined regular expression (only important for schema validation check! Therefore not really critical for implementation in my opinion)
  2. The existing regular expression for date does not meet all ISO 8601 date formats. The Industry Core Committee should therefore check on whether the regular expression should be adapted or not.

@jSchuetz88 The issues mentioned also concern the Industry Core models Batch 3.0.0 and JustinSequencePart 3.0.0.

@eckardg
Copy link

eckardg commented Nov 12, 2024

@johannsvarela : Thanks for your explanation. I agree to your proposal. Unfortunately I am not knowledgeable enough of modeling to decide about the regex question

@jSchuetz88
Copy link
Member

@eckardg In dependence of your preferred solution I might be able to help you out.

@markuskeidl
Copy link

@johannsvarela @jSchuetz88 Any idea how to fix this or if we are able to fix this for release 25.03? If not, I would remove it from the changes for 25.03 here: eclipse-tractusx/sig-release#986

@jSchuetz88
Copy link
Member

@markuskeidl This depends on the preferred solution. We can either change the Regexp, but this would be a minor change and could impact the compatibility of technical implementations. Or we could just fix the example, which would not impact the compatibility, thus could be fixed as a hotfix.

If you have a preferred way, I can prepare the Change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants