Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knowledge Agents 24.12 Release Checks #902

Closed
1 of 12 tasks
obalandi opened this issue Oct 10, 2024 · 15 comments
Closed
1 of 12 tasks

Knowledge Agents 24.12 Release Checks #902

obalandi opened this issue Oct 10, 2024 · 15 comments
Labels
knowledge agent Feature/Bug for Knowledge Agent component or KIT Prep-R24.12
Milestone

Comments

@obalandi
Copy link

obalandi commented Oct 10, 2024

Release Info

Please provide information on what you want to be included in the Eclipse Tractus-X release.
If you are not owner of this issue, please provide the information as comment to the issue.
Make sure to assign this issue to expert(s) for their approval, as soon as you have finished preparation. Multiple assignees allowed; they will un-assign themselves once review completed.

Responsible contacts:

Version to be included in Eclipse Tractus-X release:

  • App version: 1.14.24
  • Helm Chart version: 1.14.24

Leading product repository: repository link

Compliance

Make sure to open and fill in a separate documentation issue in your product repository using the Quality Gate Checklist issue template

Note

Note: most criteria for documentation and security are now covered in TRGs

Functionality

  • Feature works as expected and described
  • Backward compatibility maintained (depending Major/ Minor)

Performance

  • Memory and CPU usage is within acceptable limits oriented with goldilocks

Testing

  • Unit tests cover all new features
  • Integration tests are updated
  • E2E/Integration test passed
  • Regressions tests passed

Feature summary

Please provide a list of all features that have been developed in the current phase. This list is essential for several reasons:

  • Test Preparation: Identifying new features will help in the creation of new end-to-end (E2E) tests and ensure that the relevant aspects are thoroughly tested.
  • Awareness: It will raise awareness of the features that need to be prioritized during the testing process.
  • Board Management: This will assist in keeping the project board organized and up-to-date.

By documenting these features, you will contribute to a smoother and more efficient release process.

Note

Note: all features needs to be closed to get approval for release

Feature Test Status Note
Update of the Knowledge Agents to tractusx-edc 0.8.0 Done

Release Documentation

  • Release notes/Changelogs are updated
  • Migration scripts/documentation are included if necessary (Ensure that any database or infrastructure migrations are included).
  • Known knowns

Summary

Please provide a short summary about the new values/benefits of the new features here:

  • Update of the Knowledge Agents to tractusx-edc 0.8.0

Helpful Links

@ds-hzimmer
Copy link

Test Management review: App version 1.14.24 as described in Release Info section was tested and the Integration/E2E tests passed, as documented in detail in issue eclipse-tractusx/knowledge-agents#168

Release Check section on "Testing" above thus considered to be successful. Thanks for your efforts.

Follow-up questions for clarification:

  • Is Knowledge Agents still deployed on the Catena-X INT environment or was this only done for testing? I am not seeing the app reported in ArgoCD at the moment in a "product-knowledge-agents" namespace. Or maybe I am looking in the wrong path, as there e.g. seem to be KA components used by DPP wallet?
  • By now EDC 0.8.0-RC6 was published. Tests were run for 0.8.0-RC4 as the version available at time of testing. Do you plan to also make this update for the 24.12 release, or only continue upgrading for 25.3? Would there be a way for you to quickly test the continued functionality with the latest EDC release?

@ther3sa
Copy link
Contributor

ther3sa commented Nov 18, 2024

QG Review

  • To ensure transparency, could you please check off any topics that have already been worked on or completed?
  • I was wondering if there are no 'Known Knowns' for this issue?

Thank you for your help!

@ther3sa
Copy link
Contributor

ther3sa commented Nov 25, 2024

Hi @almadigabor,
could you update the relevant checkboxes to reflect the current status?
This will help ensure clarity on the progress.

Thank you :)

@ther3sa
Copy link
Contributor

ther3sa commented Nov 27, 2024

Hi @almadigabor , @Grand-Thibault , @obalandi, @drcgjung,
Could you give me an update about this Release check issue?

@obalandi
Copy link
Author

Test Management review: App version 1.14.24 as described in Release Info section was tested and the Integration/E2E tests passed, as documented in detail in issue eclipse-tractusx/knowledge-agents#168

Release Check section on "Testing" above thus considered to be successful. Thanks for your efforts.

Follow-up questions for clarification:

  • Is Knowledge Agents still deployed on the Catena-X INT environment or was this only done for testing? I am not seeing the app reported in ArgoCD at the moment in a "product-knowledge-agents" namespace. Or maybe I am looking in the wrong path, as there e.g. seem to be KA components used by DPP wallet?
  • By now EDC 0.8.0-RC6 was published. Tests were run for 0.8.0-RC4 as the version available at time of testing. Do you plan to also make this update for the 24.12 release, or only continue upgrading for 25.3? Would there be a way for you to quickly test the continued functionality with the latest EDC release?

Unfortunately, we do not have the capacity to run the integration and the E2E tests with release 0.8.0-RC6. We are currently working on the release deployment based on the final EDC version. Basic tests are performed automatically.

@ther3sa
Copy link
Contributor

ther3sa commented Nov 28, 2024

Test Management review: App version 1.14.24 as described in Release Info section was tested and the Integration/E2E tests passed, as documented in detail in issue eclipse-tractusx/knowledge-agents#168
Release Check section on "Testing" above thus considered to be successful. Thanks for your efforts.
Follow-up questions for clarification:

  • Is Knowledge Agents still deployed on the Catena-X INT environment or was this only done for testing? I am not seeing the app reported in ArgoCD at the moment in a "product-knowledge-agents" namespace. Or maybe I am looking in the wrong path, as there e.g. seem to be KA components used by DPP wallet?
  • By now EDC 0.8.0-RC6 was published. Tests were run for 0.8.0-RC4 as the version available at time of testing. Do you plan to also make this update for the 24.12 release, or only continue upgrading for 25.3? Would there be a way for you to quickly test the continued functionality with the latest EDC release?

Unfortunately, we do not have the capacity to run the integration and the E2E tests with release 0.8.0-RC6. We are currently working on the release deployment based on the final EDC version. Basic tests are performed automatically.

@ds-hzimmer ?

@ther3sa
Copy link
Contributor

ther3sa commented Nov 29, 2024

@obalandi, @drcgjung @almadigabor

To ensure transparency, could you please check off any topics that have already been worked on or completed?

@almadigabor
Copy link

Hi @ther3sa, I'll perform the QG checks for Knowledge Agents at the beginning of next week.

@ther3sa
Copy link
Contributor

ther3sa commented Nov 29, 2024

Hi @almadigabor,
we want to release on Monday 2.12.
Is it possible to perform the QG checks for Knowledge Agents until Monday(2.12) morning?

@almadigabor
Copy link

almadigabor commented Dec 2, 2024

Hi @ther3sa, I try to get ready until noon. Here are the releases so far. We'll have 1 more release, just need to address a Trivy finding. I'll post it here as well.

https://github.com/eclipse-tractusx/knowledge-agents-edc/releases/tag/v1.14.24
https://github.com/eclipse-tractusx/knowledge-agents-aas-bridge/releases/tag/v1.14.24

@almadigabor
Copy link

The Trivy finding has been fixed. The release is here: https://github.com/eclipse-tractusx/knowledge-agents/releases/tag/v1.14.24

@almadigabor
Copy link

almadigabor commented Dec 3, 2024

Hey @ther3sa, I've closed all 3 QGs, as every open issue have been addressed.

@almadigabor
Copy link

Hey @obalandi, could you please have a look at the remaining unchecked boxes in this issue and mark everything that's done? We'll be able to close this issue then.

@drcgjung
Copy link

drcgjung commented Dec 4, 2024

Since Oz is OOO today and only returning tomorrow (and since I can not tick the checkmarks in his ticket), here my status report:

  • No changes on related Catena-X standards are considered and addressed (just a maintenance feature)
  • Feature works as expected and described (just a maintenance feature)
  • Backward compatibility maintained (existing features are completely supported/maintained)
  • Memory and CPU usage is within acceptable limits oriented with goldilocks (default values are minimal for chart testing, recommendations for practical applications from the integration tests in the charts/admin guide)
  • Unit tests cover all new features (only maintenance)
  • Integration tests are updated (only maintenance)
  • E2E/Integration test passed (see report)
  • Regressions tests passed (part of the test suite, see report)
  • Release notes/Changelogs are updated
  • Migration scripts/documentation are included if necessary (state is provided by other components, such as EDC).
  • Known knowns (documents as open issues in the repository)

@ther3sa
Copy link
Contributor

ther3sa commented Dec 4, 2024

Based on the above checks, I can approve this issue.

Congrats 🎉

Quality Gate fully approved with all necessary pre-requisites fulfilled!


Thank you for all your efforts :)

@ther3sa ther3sa closed this as completed Dec 4, 2024
@github-project-automation github-project-automation bot moved this from Inbox to Done in Release Planning Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
knowledge agent Feature/Bug for Knowledge Agent component or KIT Prep-R24.12
Projects
Status: Done
Development

No branches or pull requests

8 participants