Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(roles): add subscribe_service permission to Business Admin #173

Conversation

typecastcloud
Copy link
Contributor

@typecastcloud typecastcloud commented Aug 19, 2024

Description

Add subscribe_service to Business Admin composite role. As defined by permission matrix.

Why

This missing permission prevented Business Admin from subscribing to services.

Issue

Refs: #172

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my changes
  • I have successfully tested my changes

This missing permission prevented Business Admin from subscribing to services.

Refs: eclipse-tractusx#172
@typecastcloud typecastcloud self-assigned this Aug 19, 2024
Copy link

@MaximilianHauer MaximilianHauer added this to the Release 24.12 milestone Sep 13, 2024
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @typecastcloud thanks for adding that! could you please also update the docs?

@typecastcloud
Copy link
Contributor Author

typecastcloud commented Sep 16, 2024

Hi @typecastcloud thanks for adding that! could you please also update the docs?

image

Hi @evegufy, in docs matrix the buisness admin composite already had the role. Just not in the import realm. Do you mean something else?

@evegufy
Copy link
Contributor

evegufy commented Sep 16, 2024

Hi @typecastcloud thanks for adding that! could you please also update the docs?

image Hi @evegufy, in docs matrix the buisness admin composite already had the role. Just not in the import realm. Do you mean something else?

Hi @typecastcloud you're right, I overlooked that, sorry.

@evegufy evegufy merged commit 417cd94 into eclipse-tractusx:main Sep 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

4 participants