Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update regex to allow special and umlaut characters #167

Conversation

JordanGerada3
Copy link
Contributor

@JordanGerada3 JordanGerada3 commented Aug 6, 2024

Description

  • Update central search field regex validation code to allow special characters and umlauts

Why

Companies that contained special characters or umlauts were not searchable via the search field.

Issue

#164

Checklist

  • I have followed the contributing guidelines
  • I have added copyright and license headers, footers (for .md files) or files (for images)
  • I have performed a self-review of my changes
  • I have successfully tested my changes
  • I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
  • I have commented my changes, particularly in hard-to-understand areas

@JordanGerada3 JordanGerada3 changed the title Fix/164 company names with special characters not searchable fix/164 company names with special characters not searchable Aug 6, 2024
@JordanGerada3 JordanGerada3 changed the title fix/164 company names with special characters not searchable fix: update regex to allow special and umlaut characters Aug 6, 2024
Copy link

sonarqubecloud bot commented Aug 6, 2024

Copy link
Contributor

@typecastcloud typecastcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Search should be at least as permissive as company names allowed via onboarding.
Small change. 👍

@evegufy
Copy link
Contributor

evegufy commented Aug 7, 2024

@oyo could you please also review?

@evegufy evegufy merged commit bf706f3 into eclipse-tractusx:main Aug 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: IN PROGRESS
Development

Successfully merging this pull request may close these issues.

4 participants