-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update regex to allow special and umlaut characters #167
Merged
evegufy
merged 4 commits into
eclipse-tractusx:main
from
JordanGerada3:fix/164-company-names-with-special-characters-not-searchable
Aug 8, 2024
Merged
fix: update regex to allow special and umlaut characters #167
evegufy
merged 4 commits into
eclipse-tractusx:main
from
JordanGerada3:fix/164-company-names-with-special-characters-not-searchable
Aug 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanGerada3
changed the title
Fix/164 company names with special characters not searchable
fix/164 company names with special characters not searchable
Aug 6, 2024
JordanGerada3
changed the title
fix/164 company names with special characters not searchable
fix: update regex to allow special and umlaut characters
Aug 6, 2024
import/keycloak-themes/catenax-central/login/resources/js/Main.js
Outdated
Show resolved
Hide resolved
Ok sure! Co-authored-by: Karsten Thiems <[email protected]>
Quality Gate passedIssues Measures |
typecastcloud
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Search should be at least as permissive as company names allowed via onboarding.
Small change. 👍
evegufy
approved these changes
Aug 7, 2024
@oyo could you please also review? |
oyo
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why
Companies that contained special characters or umlauts were not searchable via the search field.
Issue
#164
Checklist