Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BPDM authentication configuration for 24.08. release #155

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented Jul 23, 2024

Description

This pull request adjusts the Central-IDP realm configuration to be more align with the BPDM default authentication configuration for the release 24.08. / BPDM version 6.1.0 as described here

  • add Orchestrator client and permissions
  • add Orchestrator roles
  • add service accounts for Gate, Pool and Cleaning Service Dummy
  • fixes some roles and permissions for the BPDM clients

All changes were tested with BPDM to setup the golden record process successfully.

Why

Currently, the configuration between the Central-IDP and BPDM is not completely aligned. This leads to more complexity and configuration overhead for operators. Also, currently Central-IDP is missing some technical users/service accounts which is needed by an authenticated golden record process. By providing these initial service accounts an operator does not need to adapt the keycloak realm when setting up the the basic golden record process.

Issue

#154
eclipse-tractusx/bpdm#994
eclipse-tractusx/sig-release#751

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have added copyright and license headers, footers (for .md files) or files (for images)
  • I have performed a self-review of my changes
  • I have successfully tested my changes
  • I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
  • I have commented my changes, particularly in hard-to-understand areas

@nicoprow nicoprow force-pushed the feat/bpdm-auth-config-24-08 branch 2 times, most recently from 9497374 to 3939b79 Compare July 23, 2024 06:05
@nicoprow nicoprow force-pushed the feat/bpdm-auth-config-24-08 branch from 3939b79 to 046c066 Compare August 7, 2024 09:42
Copy link

sonarqubecloud bot commented Aug 7, 2024

@nicoprow nicoprow marked this pull request as ready for review August 7, 2024 09:47
@nicoprow nicoprow requested a review from evegufy August 7, 2024 09:47
@evegufy evegufy self-assigned this Aug 7, 2024
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Could you please also update the R&Rs and list of clients/service-accounts

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts in the r&r documentation

- add an Orchestrator client
- add Orchestrator client roles
- add technical roles into technical role management client
- add client scope role mappings
- add Orchestrator Admin role to BPDM admin service accounts
…lden record process

- add technical user for the Pool to access the Orchestrator component
- add technical user for the Cleaning Dummy to access the Orchestrator component
- add technical user for the Portal Gate to access the Orchestrator component
- add technical user for the Portal Gate to access the Pool component
- making sure that the Portal Data Manager has read and writing access to the Portal Gate
- giving the BPDM Pool Sharing Consumer role the permissions to read all Pool data
- restricting the BPDM Pool Consumer reading access to Pool member data only
- removing outdated write permission for the Cl16-CX-BPDMGate
…lients

- add rights and roles documentation of BPDM Orchestrator
- adapt documentation to rights and roles of BPDM Pool and Gate
- add Orchestrator client and new fine-granular BPDM service accounts to list of initial clients
@nicoprow nicoprow force-pushed the feat/bpdm-auth-config-24-08 branch from f355960 to 69d5620 Compare September 20, 2024 03:07
Copy link

@evegufy
Copy link
Contributor

evegufy commented Sep 20, 2024

Hi @typecastcloud would you like to review still or should I go head with the merge?

@typecastcloud
Copy link
Contributor

Hi @typecastcloud would you like to review still or should I go head with the merge?

I'm not able to find anything that is wrong. Go ahead.

Copy link
Contributor

@typecastcloud typecastcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have preferred changes to existing portal users and introduction of golden record tech users in separate PRs but otherwise this looks good.

@evegufy evegufy merged commit 5a73f46 into eclipse-tractusx:main Sep 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

4 participants