Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename files in src/components folder to common naming style #1238

Closed
oyo opened this issue Oct 16, 2024 · 4 comments
Closed

Rename files in src/components folder to common naming style #1238

oyo opened this issue Oct 16, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@oyo
Copy link
Contributor

oyo commented Oct 16, 2024

Current Behavior

Files in src/components folder are not named consistently

Expected Behavior

All files in a folder follow one naming style

Steps To Reproduce

open folder: https://github.com/eclipse-tractusx/portal-frontend/tree/main/src/components

See previous analysis #700 (comment)

@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Oct 16, 2024
@oyo oyo added the enhancement New feature or request label Oct 16, 2024
@oyo
Copy link
Contributor Author

oyo commented Oct 16, 2024

This is nice to have and will touch a very high number of files without real benefit for users or developers. I suggest to do this only when no other tasks are available. In case we choose to do it might be an option to script this to reduce the manual work.

@MaximilianHauer MaximilianHauer moved this from NEW USER REQUEST to IN PROGRESS in Portal Oct 21, 2024
@MaximilianHauer MaximilianHauer moved this from IN PROGRESS to BACKLOG in Portal Oct 21, 2024
@MaximilianHauer
Copy link

raised the story points due to increased effort

@evegufy
Copy link
Contributor

evegufy commented Jan 14, 2025

@oyo can this issue get closed?

@oyo
Copy link
Contributor Author

oyo commented Jan 14, 2025

@oyo can this issue get closed?

@evegufy today I merged PR #1351 which fixed most of the inconsistencies. From my pov we can close the issue now.

@evegufy evegufy closed this as completed Jan 14, 2025
@github-project-automation github-project-automation bot moved this from IN PROGRESS to USER READY in Portal Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: USER READY
Development

No branches or pull requests

4 participants