Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig#809: API Enhancement OSP Customer Management - GET /api/administration/registration/network/companies Endpoint #850

Closed
jjeroch opened this issue Jul 18, 2024 · 3 comments · Fixed by #916
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jjeroch
Copy link
Contributor

jjeroch commented Jul 18, 2024

Description:
The current endpoint GET /api/administration/registration/network/companies requires enhancements to both the response body and functionality. The following changes need to be implemented:

  1. Response Body Enhancements:

    • Add externalID field to the response body to represent the external identifier of the company.
    • Add dateCreated field to the response body to represent the creation date of the company record.
  2. New Search Functionalities:

    • Implement the ability to search by companyName to allow users to find companies more efficiently.
    • Implement the ability to search by externalID to facilitate lookup using external identifiers.
  3. New Sort Functionalities:

    • Implement sorting by dateCreated in both ascending (ASC) and descending (DESC) order.

Acceptance Criteria:

  • The response body should include the new fields externalID and dateCreated.
  • The API should support query parameters for searching by companyName and externalID.
  • The API should support query parameters for sorting by dateCreated in both ASC and DESC order.
  • Ensure that all existing functionalities are maintained and that the new features do not introduce any regressions.
  • Update the API documentation to reflect the new changes.
  • Write unit tests to cover the new functionalities and update existing tests as necessary.

Response Body Example (updated):

{
  "meta": {
    "totalElements": 0,
    "totalPages": 0,
    "page": 0,
    "contentSize": 0
  },
  "content": [
    {
      "companyId": "uuid",
      "externalID": "string",
      "applicationId": "uuid",
      "applicationStatus": "CREATED",
      "applicationDateCreated": "2024-06-24T19:43:59.670Z",
      "dateCreated": "2024-06-24T19:43:59.670Z",
      "lastChangedDate": "2024-06-24T19:43:59.670Z",
      "companyName": "string",
      "companyRoles": [
        "ACTIVE_PARTICIPANT"
      ],
      "identityProvider": [
           {
              "id": "uuid",
              "name": "aliasName"
          }
       ],
      "bpn": "string",
      "activeUsers": "{countActiveOrCreatedCompanyUsers}",
    }
  ]
}

Implementation Notes:

  • Ensure to follow the existing coding standards and architecture.
  • Review the existing endpoint to understand current functionalities.
@jjeroch jjeroch added the enhancement New feature or request label Jul 18, 2024
@jjeroch jjeroch added this to Portal Jul 18, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Jul 18, 2024
@jjeroch jjeroch moved this from NEW USER REQUEST to BACKLOG in Portal Jul 18, 2024
@jjeroch jjeroch added this to the Release 24.12 milestone Jul 18, 2024
@jjeroch jjeroch changed the title API Enhancement OSP Customer Management - GET /api/administration/registration/network/companies Endpoint sig#809: API Enhancement OSP Customer Management - GET /api/administration/registration/network/companies Endpoint Jul 19, 2024
@MaximilianHauer
Copy link

@AnuragNagpure please ensure to create a new PR for this that enables @lavanya-bmw to proceed with her frontend adjustments based on the previos ticket from you.

@ntruchsess
Copy link
Contributor

to change the sorting-order a new optional query-parameter 'dateCreatedOrderFilter' (Values 'ASC', 'DESC') has been introduced

@AnuragNagpure
Copy link
Contributor

AnuragNagpure commented Aug 13, 2024

to change the sorting-order a new optional query-parameter 'dateCreatedOrderFilter' (Values 'ASC', 'DESC') has been introduced

Thanks Norbert for this new sorting order filter introduction.

@github-project-automation github-project-automation bot moved this from IN REVIEW to USER READY in Portal Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
4 participants