Company application cancellation | Receives 409 upon cancelling the application process.

[dhiren-singh-007]

Current Behavior

Getting 409 error on passing blank comment in cancelling application process and if we try again then we get keycloak error (500)

Expected Behavior

If no comment has been passed then Cancel api should give error in early stage but it should pass after providing the comment

Steps To Reproduce

1. Login to the application as a CX admin
2. Go to application requests
3. Click on “Cancel“ button
4. Do not add any cancellation message
5. Click “confirm“ Button , you will get the 409 error
6. Now add comment and then click confirm again
7. it will throw error for "clientId *** not found on shared idp"

Error Response

{
    "type": "https://tools.ietf.org/html/rfc7231#section-6.5.8 ",
    "title": "The resorce is in conflict with the current request.",
    "status": 409,
    "errors": {
        "Org.Eclipse.TractusX.Portal.Backend.Administration.Service": [
            "No comment set."
        ]
    },
    "errorId": "08a46cb4-39f8-4b56-bd61-79834af0556a",
    "details": []
}

when Admin tries to cancel the same Company process along with Cancellation message then system returns below error message.

{
  "type": "https://datatracker.ietf.org/doc/html/rfc7231#section-6.6.1",
  "title": "The server encountered an unexpected condition.",
  "status": 500,
  "errors": {
    "Org.Eclipse.TractusX.Portal.Backend.Provisioning.Library": [
      "clientId saidp8 not found on shared idp"
    ]
  },
  "errorId": "43962feb-13a0-4c1c-baae-7811ea3e87ab",
  "details": []
}

Expected Fix

Move comment validation in before other code get executed

[dhiren-singh-007]

merged in release/v2.1.0-RC1