Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm test workflow failing #87

Closed
SebastianBezold opened this issue Nov 20, 2023 · 3 comments · Fixed by #92
Closed

Helm test workflow failing #87

SebastianBezold opened this issue Nov 20, 2023 · 3 comments · Fixed by #92
Assignees
@dvasunin @adkumar1
Labels
bug Something isn't working

Comments

@SebastianBezold
Copy link
Contributor

The Helm Test workflow is currently failing. See an example run here.

There have been changes introduces to fix the workflow in #81, but this just got the workflow a step further, until it fails with different errors this time.

Blocks #84
@SebastianBezold SebastianBezold added the bug Something isn't working label Nov 20, 2023
@SebastianBezold SebastianBezold mentioned this issue Nov 20, 2023
Closed
6 tasks
@adkumar1 adkumar1 mentioned this issue Nov 21, 2023
Closed
@adkumar1
Copy link
Contributor

adkumar1 commented Nov 21, 2023 •
edited
Loading

Workflow is green now
https://github.com/eclipse-tractusx/managed-service-orchestrator/actions/runs/6942013465

Raised a PR #88

@SebastianBezold
Copy link
Contributor Author

The workflow run you linked just skipped the part that crashed. So that is not really proof of a fix...
I'll check out the PR

@Siegfriedk
Copy link
Contributor

@adkumar1 Last week i had a meeting with Mehran regarding committer elections. One ask from myself was having proper code reviews from your own Team.

We want to see your Team doing proper code reviews! Please make sure to always have someone to verify it before we do.

@dvasunin FYI

@adkumar1 adkumar1 mentioned this issue Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvasunin dvasunin

@adkumar1 adkumar1

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@dvasunin @SebastianBezold @Siegfriedk @adkumar1