From c7c4aaf8c7116001f311eda7e7a9b0dba9ab4703 Mon Sep 17 00:00:00 2001 From: Jaro Hartmann Date: Fri, 2 Feb 2024 10:55:04 +0100 Subject: [PATCH] docs(testing):[#344] Add issue id to todos --- .../eclipse/tractusx/irs/bpdm/BpdmWiremockTest.java | 2 +- ...ecentralDigitalTwinRegistryServiceWiremockTest.java | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/irs-api/src/test/java/org/eclipse/tractusx/irs/bpdm/BpdmWiremockTest.java b/irs-api/src/test/java/org/eclipse/tractusx/irs/bpdm/BpdmWiremockTest.java index 5041293e43..b0c63f0713 100644 --- a/irs-api/src/test/java/org/eclipse/tractusx/irs/bpdm/BpdmWiremockTest.java +++ b/irs-api/src/test/java/org/eclipse/tractusx/irs/bpdm/BpdmWiremockTest.java @@ -69,7 +69,7 @@ void shouldReturnEmptyOnNotFound() { bpdmWillNotFindCompanyName(bpn); // Act & Assert - // TODO fix implementation to not throw HttpClientErrorException$NotFound + // TODO (#405) fix implementation to not throw HttpClientErrorException$NotFound assertThatExceptionOfType(HttpClientErrorException.class).isThrownBy( () -> bpdmFacade.findManufacturerName(bpn)); verifyBpdmWasCalledWithBPN(bpn, 1); diff --git a/irs-registry-client/src/test/java/org/eclipse/tractusx/irs/registryclient/decentral/DecentralDigitalTwinRegistryServiceWiremockTest.java b/irs-registry-client/src/test/java/org/eclipse/tractusx/irs/registryclient/decentral/DecentralDigitalTwinRegistryServiceWiremockTest.java index c82e73bb8b..7c6bee5b80 100644 --- a/irs-registry-client/src/test/java/org/eclipse/tractusx/irs/registryclient/decentral/DecentralDigitalTwinRegistryServiceWiremockTest.java +++ b/irs-registry-client/src/test/java/org/eclipse/tractusx/irs/registryclient/decentral/DecentralDigitalTwinRegistryServiceWiremockTest.java @@ -122,7 +122,7 @@ void shouldThrowHttpClientExceptionInCaseOfDiscoveryError() { final List testId = List.of(new DigitalTwinRegistryKey("testId", TEST_BPN)); // Act & Assert - // TODO fix implementation to not throw HttpClientErrorException$NotFound + // TODO (#405) fix implementation to not throw HttpClientErrorException$NotFound assertThatThrownBy(() -> decentralDigitalTwinRegistryService.fetchShells(testId)).isInstanceOf( HttpClientErrorException.class); verify(exactly(1), postRequestedFor(urlPathEqualTo(DISCOVERY_FINDER_PATH))); @@ -136,7 +136,7 @@ void shouldThrowHttpClientExceptionInCaseOfEdcDiscoveryError() { final List testId = List.of(new DigitalTwinRegistryKey("testId", TEST_BPN)); // Act & Assert - // TODO fix implementation to not throw HttpClientErrorException$NotFound + // TODO (#405) fix implementation to not throw HttpClientErrorException$NotFound assertThatThrownBy(() -> decentralDigitalTwinRegistryService.fetchShells(testId)).isInstanceOf( HttpClientErrorException.class); verify(exactly(1), postRequestedFor(urlPathEqualTo(DISCOVERY_FINDER_PATH))); @@ -152,7 +152,7 @@ void shouldThrowHttpClientExceptionInCaseOfLookupShellsError() { final List testId = List.of(new DigitalTwinRegistryKey("testId", TEST_BPN)); // Act & Assert - // TODO fix implementation to not throw HttpClientErrorException$NotFound + // TODO (#405) fix implementation to not throw HttpClientErrorException$NotFound assertThatThrownBy(() -> decentralDigitalTwinRegistryService.fetchShells(testId)).isInstanceOf( HttpClientErrorException.class); verify(exactly(1), postRequestedFor(urlPathEqualTo(DISCOVERY_FINDER_PATH))); @@ -170,7 +170,7 @@ void shouldThrowHttpClientExceptionInCaseOfShellDescriptorsError() { final List testId = List.of(new DigitalTwinRegistryKey("testId", TEST_BPN)); // Act & Assert - // TODO fix implementation to not throw HttpClientErrorException$NotFound + // TODO (#405) fix implementation to not throw HttpClientErrorException$NotFound assertThatThrownBy(() -> decentralDigitalTwinRegistryService.fetchShells(testId)).isInstanceOf( HttpClientErrorException.class); verify(exactly(1), postRequestedFor(urlPathEqualTo(DISCOVERY_FINDER_PATH))); @@ -189,7 +189,7 @@ void shouldThrowExceptionOnEmptyShells() { final List testId = List.of(new DigitalTwinRegistryKey("testId", TEST_BPN)); // Act & Assert - // TODO fix implementation to not throw HttpClientErrorException$NotFound + // TODO (#405) fix implementation to not throw HttpClientErrorException$NotFound assertThatThrownBy(() -> decentralDigitalTwinRegistryService.fetchShells(testId)).isInstanceOf( HttpClientErrorException.class); verify(exactly(1), postRequestedFor(urlPathEqualTo(DISCOVERY_FINDER_PATH)));