From 0cfba0fc19a8aae81e1ad17207731cd6b62ab06a Mon Sep 17 00:00:00 2001
From: Matthias Fischer <matthias.fischer@doubleslash.de>
Date: Fri, 2 Feb 2024 15:49:41 +0100
Subject: [PATCH] feat(imp):[#214] improved variable naming and code comment

---
 .../common/util/concurrent/ResultFinder.java  | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/irs-common/src/main/java/org/eclipse/tractusx/irs/common/util/concurrent/ResultFinder.java b/irs-common/src/main/java/org/eclipse/tractusx/irs/common/util/concurrent/ResultFinder.java
index 9430e623df..7d7307e03c 100644
--- a/irs-common/src/main/java/org/eclipse/tractusx/irs/common/util/concurrent/ResultFinder.java
+++ b/irs-common/src/main/java/org/eclipse/tractusx/irs/common/util/concurrent/ResultFinder.java
@@ -62,13 +62,15 @@ public <T> CompletableFuture<T> getFastestResult(final List<CompletableFuture<T>
 
         log.debug("Trying to get fastest result from list of futures");
 
-        final CompletableFuture<T> fastestResultPromise = new CompletableFuture<>();
+        // The purpose of this overall future is to track when the first data request is successful.
+        // This way we do not need to wait for the others to complete.
+        final CompletableFuture<T> overallFuture = new CompletableFuture<>();
 
         final List<Throwable> exceptions = new ArrayList<>();
 
         final var futuresList = futures.stream()
                                        .map(future -> future.exceptionally(collectingExceptionsAndThrow(exceptions))
-                                                            .handle(completingOnFirstSuccessful(fastestResultPromise)))
+                                                            .handle(completingOnFirstSuccessful(overallFuture)))
                                        .toList();
 
         allOf(toArray(futuresList)).whenComplete((value, ex) -> {
@@ -81,14 +83,14 @@ public <T> CompletableFuture<T> getFastestResult(final List<CompletableFuture<T>
                                     .map(ExceptionUtils::getStackTrace)
                                     .collect(Collectors.joining(System.lineSeparator())), ex);
 
-                fastestResultPromise.completeExceptionally(new CompletionExceptions("None successful", exceptions));
+                overallFuture.completeExceptionally(new CompletionExceptions("None successful", exceptions));
             } else {
                 log.debug("Completing");
-                fastestResultPromise.complete(null);
+                overallFuture.complete(null);
             }
         });
 
-        return fastestResultPromise;
+        return overallFuture;
     }
 
     private static <T> CompletableFuture<T>[] toArray(final List<CompletableFuture<T>> handledFutures) {
@@ -96,22 +98,21 @@ private static <T> CompletableFuture<T>[] toArray(final List<CompletableFuture<T
     }
 
     private static <T> BiFunction<T, Throwable, Boolean> completingOnFirstSuccessful(
-            final CompletableFuture<T> resultPromise) {
+            final CompletableFuture<T> overallFuture) {
 
         return (value, throwable) -> {
 
             log.debug("value: '{}', throwable: {}", value, throwable);
 
-            final boolean notFinishedByOtherFuture = !resultPromise.isDone();
+            final boolean notFinishedByOtherFuture = !overallFuture.isDone();
             log.debug("notFinishedByOtherFuture {} ", notFinishedByOtherFuture);
 
             final boolean currentFutureSuccessful = throwable == null && value != null;
 
             if (notFinishedByOtherFuture && currentFutureSuccessful) {
 
-                // first future that completes successfully completes the overall future
                 log.debug("First future that completed successfully");
-                resultPromise.complete(value);
+                overallFuture.complete(value);
                 return true;
 
             } else {