Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modular-production-kit): export drawio images as svg #960

Conversation

dominikoeh
Copy link
Contributor

Description

  • removes warnings during build regarding unsupported image formats
  • adds drawio diagrams for later use

fixes #945

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

- removes warnings during build regarding unsupported image formats
- adds drawio diagrams for later use
@dominikoeh dominikoeh marked this pull request as draft July 5, 2024 07:42
@dominikoeh dominikoeh marked this pull request as ready for review July 5, 2024 11:45
Copy link
Contributor

@arnoweiss arnoweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix - much apprec

@arnoweiss arnoweiss requested a review from maximilianong July 26, 2024 08:07
@stephanbcbauer
Copy link
Member

@jSchuetz88 since this PR adapts something in the version KITs for 24.03 and we don't have 24.03 displayed any more... can this PR just be closed?

@arnoweiss arnoweiss closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Modular Production] Fix SVGs
3 participants