From 13bf9ca1c52e6b87da465a24f1c30ed8ef2d2f2f Mon Sep 17 00:00:00 2001 From: Nico Koprowski Date: Fri, 23 Aug 2024 18:12:59 +0800 Subject: [PATCH] fix(Cleaning Dummy): add whitespace between name parts when creating legal name from them --- CHANGELOG.md | 1 + .../tractusx/bpdm/cleaning/service/CleaningServiceDummy.kt | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2760388a9..c3f73eb3f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ For changes to the BPDM Helm charts please consult the [changelog](charts/bpdm/C - BPDM Pool & Gate: Reduce standard batch size for golden record task processing ([#1032](https://github.com/eclipse-tractusx/bpdm/pull/1032)) - BPDM Orchestrator: Fix possible out-of-memory exception during the execution of large volumes of tasks ([#1029](https://github.com/eclipse-tractusx/bpdm/pull/1029)) +- BPDM Cleaning Service Dummy: Add whitespaces between name parts when creating legal name from them - BPDM Cleaning Service Dummy: Improve duplication check to better distinguish between incoming business partners ## [6.1.0] - [2024-07-15] diff --git a/bpdm-cleaning-service-dummy/src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummy.kt b/bpdm-cleaning-service-dummy/src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummy.kt index 10d31ed95..d87a88aab 100644 --- a/bpdm-cleaning-service-dummy/src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummy.kt +++ b/bpdm-cleaning-service-dummy/src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummy.kt @@ -108,7 +108,7 @@ class CleaningServiceDummy( return with(businessPartner.legalEntity){ copy( bpnReference = bpnReference.toRequestIfNotBpn(businessPartner.legalEntityReference()), - legalName = legalName ?: businessPartner.uncategorized.nameParts.joinToString(""), + legalName = legalName ?: businessPartner.uncategorized.nameParts.joinToString(" "), identifiers = identifiers.takeIf { it.isNotEmpty() } ?: businessPartner.uncategorized.identifiers, states = states.takeIf { it.isNotEmpty() } ?: businessPartner.uncategorized.states, confidenceCriteria = dummyConfidenceCriteria.copy(sharedByOwner = sharedByOwner),