Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo-data not displaying all digits in the gate #978

Closed
HeyHardy opened this issue Jun 25, 2024 · 2 comments · Fixed by #1049
Closed

Geo-data not displaying all digits in the gate #978

HeyHardy opened this issue Jun 25, 2024 · 2 comments · Fixed by #1049
Assignees
Labels
bug Something isn't working golden record Issues relating to the Golden Record process not reproducable Specifically for a bug which can't be reproduced

Comments

@HeyHardy
Copy link

the geo-data should display all digits written in the pool and input stage from sharing member

Latitude: -25.79753 and Longitude: -80.29847
Latitude: 80.29847 and Longitude: -25.79753
Latitude: -80.29847 and Longitude: 25.79753

Current Behavior

in Longitude only 2 digits after comma are displaying and sometime its rounded.

Latitude: -25.79753 and Longitude: -80.29
Latitude: 80.29847 and Longitude: -25.8
Latitude: -80.29847 and Longitude: 25.79

@HeyHardy HeyHardy added the bug Something isn't working label Jun 25, 2024
@HeyHardy HeyHardy added the golden record Issues relating to the Golden Record process label Jun 25, 2024
@HeyHardy HeyHardy moved this to New in BPDM Kanban Jun 26, 2024
@SujitMBRDI
Copy link
Contributor

@HeyHardy, I tried to replicate this issue, but I couldn't able to see any scenario where the longitude and latitude values are getting rounded of. Technically we are using Float data type for these attributes which is having wide range so rounding off should not happen.
If you have specific test record/data with you then kindly provide to me so I can cross check.

@nicoprow nicoprow added the not reproducable Specifically for a bug which can't be reproduced label Jul 24, 2024
@nicoprow nicoprow removed their assignment Aug 1, 2024
@nicoprow nicoprow moved this from New to 👀 In review in BPDM Kanban Aug 1, 2024
@babafareed-bikkusab
Copy link

babafareed-bikkusab commented Aug 9, 2024

Hi @SujitMBRDI, @nicoprow,

I would like to elaborate the issues which we faced regarding this latitude and longitude fields in our BPDM Gate.
At present we are considering the latitude and longitude value as valid, only if it is having a 6 decimal points.
When we try to insert a record into our Gate with the values "longitude": -80.212389,
"latitude": -25.791759.
When we try to fetch that particular record from the Gate, it is returning as "longitude": -80.21239,
"latitude": -25.79176, which results as a invalid Geo coordinates in our case. I understand that here the issue with the data type float, it is automatically rounding it off to the nearest value. But this is creating a confusion for us, even though we give 6 decimal Geo coordinates, as it is returning it as 5 decimal. We will be end up by considering this as invalid Geo coordinates.
Can you please help us regarding this, do you see any risk of considering the latitude, longitude as a string data type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working golden record Issues relating to the Golden Record process not reproducable Specifically for a bug which can't be reproduced
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants