Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate: Connect Sharing State with One-to-One Relation to Generic Business Partners #439

Closed
Tracked by #382
alexsilva-CGI opened this issue Sep 6, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@alexsilva-CGI
Copy link
Contributor

alexsilva-CGI commented Sep 6, 2023

Add a field to link to the generic Business Partner by databaseID.

Currently, when upserting an Legal Entity, Site or Address, an new row is created in the Sharing_States table, with the corresponding BusinessPartnerType and ExternalID from the upserted L/S/A.

Regarding the new Generic Business Partner, it will not have an BusinessPartnerType, so this field cannot be used in a creation of an new Sharing State, only the ExternalID.

Current question is if the BusinessPartnerType in the sharing state should be deprecated regarding this?

Solution: BusinessPartnerType will be optional on Sharing_States. Direct connection between Sharing State and Generic Business Partner will be done by the ExternalID.

@martinfkaeser
Copy link
Contributor

@nicoprow
It's not clear how SharingState and BusinessPartner should exactly be linked because for every externalId there is just one SharingState but two BusinessPartners in different stages.

@nicoprow
Copy link
Contributor

@nicoprow It's not clear how SharingState and BusinessPartner should exactly be linked because for every externalId there is just one SharingState but two BusinessPartners in different stages.

In my opinion business partners in different stages should share the same sharing state. I think we already mentioned before that there is merit in the idea to rename sharing state to business partner and the current business partner to business partner stage. In my opinion this is a change that we could do after migrating the typed LSA business partners to the generic business partner model.

@nicoprow nicoprow added enhancement New feature or request Gate labels Sep 13, 2023
@nicoprow
Copy link
Contributor

At this moment we do not intend to support L/S/A endpoints entering the golden record process through the orchestrator. For this reason attaching L/S/A to the service logic is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants