From 810e27cdcb1a61e9c46b83eee25122f17e11ecdb Mon Sep 17 00:00:00 2001 From: Nico Koprowski Date: Fri, 10 Mar 2023 10:22:01 +0100 Subject: [PATCH 1/3] fix(Gate-Type-Match): faulty binding between SaaS response and data model --- .../bpdm/common/dto/saas/ReferenceDataLookupResponseSaas.kt | 1 - 1 file changed, 1 deletion(-) diff --git a/bpdm-common/src/main/kotlin/org/eclipse/tractusx/bpdm/common/dto/saas/ReferenceDataLookupResponseSaas.kt b/bpdm-common/src/main/kotlin/org/eclipse/tractusx/bpdm/common/dto/saas/ReferenceDataLookupResponseSaas.kt index 67ff9e8dd..69d6c11b4 100644 --- a/bpdm-common/src/main/kotlin/org/eclipse/tractusx/bpdm/common/dto/saas/ReferenceDataLookupResponseSaas.kt +++ b/bpdm-common/src/main/kotlin/org/eclipse/tractusx/bpdm/common/dto/saas/ReferenceDataLookupResponseSaas.kt @@ -28,7 +28,6 @@ data class ReferenceDataLookupResponseSaas( ) data class BusinessPartnerLookupMatchSaas( - val saasId: String, val dataSource: String, val matchingProfile: MatchingProfileSaas ) From 1852812929fcb62749d7aeb44c7a6be8a4dbf9c4 Mon Sep 17 00:00:00 2001 From: Nico Koprowski Date: Fri, 10 Mar 2023 10:24:06 +0100 Subject: [PATCH 2/3] docs(Changelog): add type match fix description --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a70fafd1f..022f6487c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ The format is based on Keep a Changelog (https://keepachangelog.com/en/1.0.0/), ## [3.1.1] - tbd +### Fixed + +- BPDM Gate: internal server error when invoking the POST business-partners/type-match endpoint + ## [3.1.0] - 2023-03-08 ### Changed From 68ea08f4cf2308f6452139b170a3a6a93daa7bc4 Mon Sep 17 00:00:00 2001 From: Nico Koprowski Date: Fri, 10 Mar 2023 11:16:02 +0100 Subject: [PATCH 3/3] test(Gate-Type-Match): fix mock response used in test cases --- .../bpdm/gate/controller/BusinessPartnerControllerIT.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bpdm-gate/src/test/kotlin/org/eclipse/tractusx/bpdm/gate/controller/BusinessPartnerControllerIT.kt b/bpdm-gate/src/test/kotlin/org/eclipse/tractusx/bpdm/gate/controller/BusinessPartnerControllerIT.kt index a9361a70b..89e1e5082 100644 --- a/bpdm-gate/src/test/kotlin/org/eclipse/tractusx/bpdm/gate/controller/BusinessPartnerControllerIT.kt +++ b/bpdm-gate/src/test/kotlin/org/eclipse/tractusx/bpdm/gate/controller/BusinessPartnerControllerIT.kt @@ -203,7 +203,7 @@ class BusinessPartnerControllerIT @Autowired constructor( 1, 1, 0, 1, listOf( BusinessPartnerLookupMatchSaas( - "0", "0", + "0", MatchingProfileSaas( MatchingScoresSaas(MatchingScoreSaas(0.5f), MatchingScoreSaas(0.5f), MatchingScoreSaas(overallScore)) )