Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Java 17 as BREE #339

Closed
mickaelistria opened this issue Apr 13, 2022 · 11 comments
Closed

Consider Java 17 as BREE #339

mickaelistria opened this issue Apr 13, 2022 · 11 comments

Comments

@mickaelistria
Copy link
Contributor

Java 17 is LTS, JustJ ships support for it so it would still run well in recent Eclipse IDE packages, and it has tons of good features that TM4E could leverage.
So this is a call to active contributors (as per https://projects.eclipse.org/projects/technology.tm4e/who ): @sebthom @akurtakov @danipen would you be in favor of moving to Java 17 as BREE to leverage its new features?

@akurtakov
Copy link
Contributor

I'm fine with the proposal in general. Do you guys think we should announce it wider now (cross-project?) with goal being to do so for September release?
If you're all set on that and want to do it right now so be it. IMO such change that affects many projects using it is better delivered in M1 though.

@mickaelistria
Copy link
Contributor Author

I've announced that intent to appropriate mailing-lists so that downstream consumers can be prepared.

@martinlippert
Copy link

I would like to draw your attention to eclipse-buildship/buildship#1147 from the Buildship project, which describes basically a tight coupling between the JRE that is used to run the IDE and the version of Gradle that a project uses and which has certain JRE compatibilities (the Gradle version of the project MUST support the JRE of the IDE).

To cut a long story short: as long as this issue isn't resolved (and I don't expect this to be resolved anytime soon), users continue to have two options to workaround this limitation in buildship:

  • they upgrade the Gradle version of each project (to make the IDE happy)
  • they change the JRE to run the IDE (to make the projects happy)

(very short and sloppy summary here, for more details please refer to the Buildship issue mentioned above)

An upgrade of TM4E to require a Java 17 as BREE would remove (more or less) the second option. The only choice would be to upgrade project definitions (or to not use Buildship, of course).

So I think an upgrade of TM4E to require Java 17 as BREE has some wider consequences, so having more time for people involved to mitigate those consequences (in one way or the other) would be great.

@mickaelistria
Copy link
Contributor Author

@martinlippert I suggest you share this with the cross-project-issues-dev mailing-list for a wider audience.

@akurtakov
Copy link
Contributor

Do we have an agreement that TM4E delivers Java 11 based release for 2022-06 and switch to Java 17 after that?

@mickaelistria
Copy link
Contributor Author

Yes, next release will support Java 11 and is due this month to get into 2022-06; then we switch to Java 17.
@sebthom As you're doing most of the work, please ping when you think it's the best time for a release.

@sebthom
Copy link
Member

sebthom commented May 10, 2022

@mickaelistria I think I am done for now. Before tackeling #38 I want to wait for the next release of vscode-textmate where they did quite some refactoring.

@mickaelistria
Copy link
Contributor Author

OK. So you're OK if we release right now? And then we start bumping BREEs and adopting relevant newer Java constructs and APIs on master after that?

@sebthom
Copy link
Member

sebthom commented May 10, 2022

That is fine with me.

@mickaelistria
Copy link
Contributor Author

I started the process of releasing TM4E but a review will be required this time, so that adds a few days of delay.

@mickaelistria
Copy link
Contributor Author

Done with #395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants