From 7bb9c50fb2470a486fbe2648db23a33e571655a3 Mon Sep 17 00:00:00 2001 From: Scott Axcell Date: Sun, 6 Jun 2021 21:46:38 -0600 Subject: [PATCH] File dialog filters do not work Only use the default * filter when no filter has been specified in the SaveFileDialogProps props. Signed-off-by: Scott Axcell --- .../file-dialog/electron-file-dialog-service.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/filesystem/src/electron-browser/file-dialog/electron-file-dialog-service.ts b/packages/filesystem/src/electron-browser/file-dialog/electron-file-dialog-service.ts index 1c93f41ef7d2e..9b2cf3c1d2647 100644 --- a/packages/filesystem/src/electron-browser/file-dialog/electron-file-dialog-service.ts +++ b/packages/filesystem/src/electron-browser/file-dialog/electron-file-dialog-service.ts @@ -93,9 +93,11 @@ export class ElectronFileDialogService extends DefaultFileDialogService { protected toDialogOptions(uri: URI, props: SaveFileDialogProps | OpenFileDialogProps, dialogTitle: string): electron.FileDialogProps { const title = props.title || dialogTitle; const defaultPath = FileUri.fsPath(uri); - const filters: FileFilter[] = [{ name: 'All Files', extensions: ['*'] }]; + const filters: FileFilter[] = []; if (props.filters) { filters.push(...Object.keys(props.filters).map(key => ({ name: key, extensions: props.filters![key] }))); + } else { + filters.push({ name: 'All Files', extensions: ['*'] }); } return { title, defaultPath, filters }; }