[theming] file-icon incorrectly displays name icon with a dot in name

[kesslerdev]

Bug Description:

The file-icon is incorrectly displayed for files with a dot in name.
For instance, the icon for the following file package.json is not properly displayed (with: https://marketplace.visualstudio.com/items?itemName=PKief.material-icon-theme)

Theia

VS Code

Resolution

Theia

when a class contain a dot in name, in html element don't need to escape dot but in css style definition yes!

.theia-plugin-package\.json-file-name-icon.theia-plugin-json-ext-file-icon.theia-plugin-ext-file-icon.theia-plugin-file-icon, .theia-plugin-package\.json-file-name-icon.theia-plugin-json-ext-file-icon.theia-plugin-ext-file-icon.theia-plugin-file-icon::before, .theia-plugin-package-lock\.json-file-name-icon.theia-plugin-json-ext-file-icon.theia-plugin-ext-file-icon.theia-plugin-file-icon, .theia-plugin-package-lock\.json-file-name-icon.theia-plugin-json-ext-file-icon.theia-plugin-ext-file-icon.theia-plugin-file-icon::before, .theia-plugin-\.nvmrc-file-name-icon.theia-plugin-nvmrc-ext-file-icon.theia-plugin-ext-file-icon.theia-plugin-file-icon, .theia-plugin-\.nvmrc-file-name-icon.theia-plugin-nvmrc-ext-file-icon.theia-plugin-ext-file-icon.theia-plugin-file-icon::before, .theia-plugin-\.esmrc-file-name-icon.theia-plugin-esmrc-ext-file-icon.theia-plugin-ext-file-icon.theia-plugin-file-icon, .theia-plugin-\.esmrc-file-name-icon.theia-plugin-esmrc-ext-file-icon.theia-plugin-ext-file-icon.theia-plugin-file-icon::before {
    content: ' ';
    background-image: url('http://127.0.0.1:3000/hostedPlugin/PKief_material_icon_theme/icons/nodejs.svg');
    background-size: 16px;
    background-position: left center;
    background-repeat: no-repeat;
}

Additional Information

• Operating System: Linux / docker
• Theia Version: next

[akosyakov]

Class name is constructed here: https://github.com/eclipse-theia/theia/blob/master/packages/plugin-ext/src/main/browser/plugin-icon-theme-service.ts#L463