search-in-workspace: IncludeInputBox contextKey typo #12385
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This commit fixes a typo where the
handleFocusIncludesInputBox
called thesetPatternExcludesInputBoxFocus
instead of thesetPatternIncludesInputBoxFocus
How to test
You can test this by calling a command restricted by the context-key. You can do this by modifying the keybindings.
keymaps.json
About
dialog.About
dialog can be opened using the keybinding.Issue
Fixed
Notes
For this test to properly work you need your preferences to have
"window.titleBarStyle": "custom"
as the native menus in electron do not support thewhen
clause properly. To avoid this, you can use the browser version.Review checklist
Reminder for reviewers