Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search-in-workspace: IncludeInputBox contextKey typo #12385

Conversation

FernandoAscencio
Copy link
Contributor

@FernandoAscencio FernandoAscencio commented Apr 6, 2023

What it does

This commit fixes a typo where the handleFocusIncludesInputBox called the setPatternExcludesInputBoxFocus instead of the setPatternIncludesInputBoxFocus

How to test

You can test this by calling a command restricted by the context-key. You can do this by modifying the keybindings.

  1. Load Theia in Browser
  2. Open keymaps.json
  3. Add the following
    image
  4. Using the keybinds while focused in the exclude inputbox should call the About dialog.
  5. Move focus on the include inputbox.
  6. Check whether the About dialog can be opened using the keybinding.

Issue
IssueContextKeySIW2

Fixed
FixedContextKeySIW2

Notes

For this test to properly work you need your preferences to have "window.titleBarStyle": "custom" as the native menus in electron do not support the when clause properly. To avoid this, you can use the browser version.

Review checklist

Reminder for reviewers

This commit fixes a typo where the `handleFocusIncludesInputBox`
called the `setPatternExcludesInputBoxFocus` instead of the
`setPatternIncludesInputBoxFocus`

Signed-Off-By: FernandoAscencio <[email protected]>
@vince-fugnitto vince-fugnitto added the search in workspace issues related to the search-in-workspace label Apr 10, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I confirmed the context-key now works as expected, and the changes make sense.

@vince-fugnitto vince-fugnitto merged commit ceb48a5 into eclipse-theia:master Apr 10, 2023
@vince-fugnitto vince-fugnitto deleted the fa/IncludeInputBox-contextKey-typo branch April 10, 2023 13:49
@paul-marechal paul-marechal added this to the 1.37.0 milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
search in workspace issues related to the search-in-workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants