Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check renderer schema when updating preference renderers #12347

Merged
merged 6 commits into from
Mar 29, 2023
Merged

Check renderer schema when updating preference renderers #12347

merged 6 commits into from
Mar 29, 2023

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes #12345

How to test

  1. Follow Improve theme preference selection #11678

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the preferences issues related to preferences label Mar 23, 2023
@colin-grant-work colin-grant-work requested a review from msujew March 23, 2023 21:39
@colin-grant-work colin-grant-work changed the title Use nodes' schemata as source of truth Check renderer schema when updating preference renderers Mar 23, 2023
msujew
msujew reviewed Mar 23, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a regression for installing theme extensions. Due to the issue outlined in the comment below, the preference renderer isn't updated and continues to show the old values.

packages/preferences/src/browser/views/preference-editor-widget.ts Show resolved Hide resolved
@colin-grant-work colin-grant-work force-pushed the bugfix/preference-schema-change-handling branch from 67b1e8e to d5a0bd8 Compare March 24, 2023 14:47
@colin-grant-work colin-grant-work requested a review from msujew March 27, 2023 22:28
msujew
msujew approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, that makes way more sense than just modifying the preference data in-place. Looks good to me, thanks 👍

@colin-grant-work colin-grant-work merged commit f82e52b into eclipse-theia:master Mar 29, 2023
@colin-grant-work colin-grant-work deleted the bugfix/preference-schema-change-handling branch March 29, 2023 13:14
@vince-fugnitto vince-fugnitto added this to the 1.36.0 milestone Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
preferences issues related to preferences
Projects
None yet
Milestone
1.36.0
Development

Successfully merging this pull request may close these issues.

Preference node rendered incorrectly after schema change
3 participants
@colin-grant-work @msujew @vince-fugnitto