terminal: fix 'new terminal' handling #12322
Merged
Commits on Mar 23, 2023
-
terminal: fix 'new terminal' handling
The commit fixes a regression with `new terminal` and `new terminal (with profile)` which did not open successfully when no workspace root was present. The code fixes the issue and also refactors the logic to remove unnecessary duplication. Signed-off-by: vince-fugnitto <[email protected]>
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.