terminal: fix 'new terminal' handling #12322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
force-pushed
the
vf/fix-new-terminal
branch
from
5c59e98 to
5439636
Compare
PKhamorn302531
approved these changes
Mar 19, 2023
colin-grant-work
approved these changes
Mar 22, 2023
The commit fixes a regression with `new terminal` and `new terminal (with profile)` which did not open successfully when no workspace root was present. The code fixes the issue and also refactors the logic to remove unnecessary duplication. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/fix-new-terminal
branch
from
5439636 to
cc97962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request fixes a regression from #12199 which prevented new terminals from being opened without a workspace present. Previously the code would prompt users to select a
cwdand exit early when nocwdwas selected or no workspace was present. The code now adds handling to only prompt to select thecwdif a workspace is present.The code also refactors the logic for
openTerminaland removesopenTerminalFromProfilewhich duplicated code.How to test
No Workspace:
new terminalandnew terminal (with profile)correctly spawn a terminal with the appropriate profile at the user's home (no cwd)Non-Multi Root Workspace:
new terminalandnew terminal (with profile)correctly spawn a terminal with the appropriate profile at the workspace's rootMulti-Root Workspace:
add folder to workspace commands)new terminalReview checklist
Reminder for reviewers