Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: provide error feedback for the vscode.open command #12284

Merged

Conversation

FernandoAscencio
Copy link
Contributor

@FernandoAscencio FernandoAscencio commented Mar 10, 2023

What it does

Partial implementation of #6568.
Fixes #5667.

This commit implements error messages when a file is not found using the vscode.open command.

How to test

  1. Download open-some-file-0.0.4.zip
  2. Run Some: Open File command.
  3. Check the error message appears

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Mar 14, 2023
Partial implementation of 6568.
Closes 5667 until there is closer implementation to VS Code.

Signed-Off-By: FernandoAscencio <[email protected]>
Co-authored-by: Vincent Fugnitto <[email protected]>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I confirmed that the message is correctly reported now to end-users and logged for additional information.

@vince-fugnitto vince-fugnitto merged commit 09457be into eclipse-theia:master Apr 10, 2023
@vince-fugnitto vince-fugnitto deleted the fa/vscOpenErrorMsg branch April 10, 2023 18:50
@vince-fugnitto vince-fugnitto changed the title vscode: Error feddback with vscode.open command vscode: provide error feedback for the vscode.open command Apr 10, 2023
@vince-fugnitto vince-fugnitto added this to the 1.37.0 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vscode] No error message if vscode.open command is invoked with resource that doesn't exist
2 participants