Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not (re)store state of Open Editors #12210

Conversation

colin-grant-work
Copy link
Contributor

What it does

Removes state restoration for Open Editors widget. Because tree nodes in the Open Editors widget include a reference to a widget, they were triggering double state restoration for all editor widgets in the application. Since the state of the Open Editors widget is entirely derived, there's no need to store or restore it.

How to test

  1. Start the application.
  2. Open and close editors.
  3. The Open Editors widget should behave normally.

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the open-editors issues related to the open-editors view label Feb 23, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the changes work as expected 👍
The open-editors are properly updated when editors are opened, and are restored (not by state) when the application is started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-editors issues related to the open-editors view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants