Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: drop support for Node 14 #12169

Merged
merged 2 commits into from
Feb 14, 2023
Merged

repo: drop support for Node 14 #12169

merged 2 commits into from
Feb 14, 2023

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request drops support for Node 14 in the framework in oder to better support the runtime plugins expect when targeting the 1.68.1 VS Code API.

How to test

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The commit drops support for `Node 14` in the framework, and updates documentation, CI, and typings.

Signed-off-by: vince-fugnitto <[email protected]>
Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto marked this pull request as ready for review February 13, 2023 13:28
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well 👍

@paul-marechal paul-marechal merged commit ac339db into master Feb 14, 2023
@paul-marechal paul-marechal deleted the vf/drop-14 branch February 14, 2023 15:43
@github-actions github-actions bot added this to the 1.35.0 milestone Feb 14, 2023
@vince-fugnitto vince-fugnitto added quality issues related to code and application quality builtins Issues related to VS Code builtin extensions labels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins Issues related to VS Code builtin extensions quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants