Automatically generate plugin activation events #12167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #12161
When loading a plugin, this change automatically deduces some of its activation events from the plugin manifest.
This change also adds a few more entries to the manifest types, which were required for this to work correctly.
I also did a drive-by cleanup of the
scanner-theia
file. A lot of the non-null assertions were no longer required due to advancements of TypeScript type checker.How to test
activationEvents
removed.Hello World
commandReview checklist
Reminder for reviewers