Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure uniqueness of roots #12159

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Ensure uniqueness of roots #12159

merged 1 commit into from
Feb 10, 2023

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes #12155 by using a Set to ensure uniqueness of roots when parsing a workspace file.

How to test

  1. Follow steps from Unresponsive Page When duplicate workspace url in theia-workspace file #12155
  2. Observe that the UI does not freeze up and the explorer shows only one copy of the repeated root.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the workspace issues related to the workspace label Feb 7, 2023
vince-fugnitto
vince-fugnitto approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I confirm that the updates properly handle the duplicate roots and falls on it's feet accordingly (by dismissing any duplicates).

@colin-grant-work colin-grant-work merged commit 81dd3ba into eclipse-theia:master Feb 10, 2023
@colin-grant-work colin-grant-work deleted the bugfix/repeated-folder-freezes-application branch February 10, 2023 16:36
@colin-grant-work colin-grant-work added this to the 1.35.0 milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
workspace issues related to the workspace
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.

Unresponsive Page When duplicate workspace url in theia-workspace file
2 participants
@colin-grant-work @vince-fugnitto