Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove RpcProtocol from task test #12054

Merged
merged 1 commit into from
Jan 10, 2023
Merged

remove RpcProtocol from task test #12054

merged 1 commit into from
Jan 10, 2023

Conversation

paul-marechal
Copy link
Member

@paul-marechal paul-marechal commented Jan 10, 2023

One of the task test cases relies on the protocol used by terminals to communicate data, but the protocol has been updated in #11972.

How to test

CI should be green.

Review checklist

Reminder for reviewers

One of the task test cases relies on the protocol used by terminals
to communicate data, but the protocol has been updated in #11972.
@vince-fugnitto vince-fugnitto added the tasks issues related to the task system label Jan 10, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 CI is green again (besides the known flakiness)

@paul-marechal paul-marechal merged commit 5bafaa5 into master Jan 10, 2023
@paul-marechal paul-marechal deleted the mp/task-test-fix branch January 10, 2023 13:43
@github-actions github-actions bot added this to the 1.34.0 milestone Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks issues related to the task system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants