Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization for '(deleted)' tab suffix #12032

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

xcariba
Copy link
Contributor

@xcariba xcariba commented Dec 29, 2022

What it does

Fixed #11971.

Now tab (deleted) suffix is localized. Fixed without refactoring as this suffix is used in some logic.

How to test

  • Build theia
  • Start instance and open folder
  • Install any language pack that has this translation (tested on Russian, it as this string)
  • Switch display language and restart
  • Create any file, write something and save
  • Delete file from explorer view
  • it will show myFile.txt (удален) instead of myFile (deleted)

Review checklist

Reminder for reviewers

@xcariba xcariba force-pushed the fix-deleted-tab-locale branch from ac57692 to 7ff7a46 Compare December 29, 2022 12:04
@msujew msujew added the localization issues related to localization/internalization/nls label Jan 9, 2023
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@msujew msujew merged commit e4621d1 into eclipse-theia:master Jan 9, 2023
@paul-marechal paul-marechal added this to the 1.34.0 milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On editor tab ' (deleted)' suffix is not localized
3 participants