Update nsfw library to v2.2.4.

[tsmaeder]

What it does

Updates nsfw dependency to v. 2.2.4 Fixes #11431
The update contains a fix I did Axosoft/nsfw#172 that should fix the issue and (hopefully) also get rid of the frequent PR check failures on ubuntu.

Contributed on behalf of ST Microelectronics

How to test

Manipulate file and folders in the workspace and make sure that they are properly reflected in Theia. I was able to reproduce the original issue by simple doing this:

1. Make a copy of the Theia node_modules folder
2. Open the folder as the workspace in Theia
3. In the file explorer, select all the subfolders and press "delete". This moves the files to a trash folder.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[paul-marechal]

I don't understand what fails on CI, but note that https://github.com/eclipse-theia/theia/actions/runs/3656095808/jobs/6178414596#step:9:4720 means we have a double free/dispose on one of the watchers for some reason.

[marcdumais-work]

I see the exact same error on other PRs, so I do not think this is related to the nsfw update:
https://github.com/eclipse-theia/theia/actions/runs/3676473534/jobs/6217643338#step:9:4156

[tsmaeder]

I don't have the time right now to look at the failures.

[marcdumais-work]

I restarted the two failing test suites. Something is flaky, and if we retry it eventually passes, from what I have seen.

@paul-marechal Running the tests locally for something else and without the nsfw update, I just got a double "watcher dealocation" issue.

2022-12-15T14:21:51.821Z root INFO     ✅ should toggle Explorer (83ms)
2022-12-15T14:21:51.894Z root INFO     ✅ should toggle Source Control (67ms)
2022-12-15T14:21:51.954Z root INFO     ✅ should toggle Outline (55ms)
2022-12-15T14:21:52.008Z root INFO     ✅ should toggle Problems (48ms)
2022-12-15T14:21:52.076Z root INFO     ✅ should toggle Properties (66ms)
2022-12-15T14:21:52.101Z root ERROR [nsfw-watcher: 1803813] NSFW service error on "/tmp/theia-test-config-dir20221115-1803724-xolbsv.tqk6h": [Error: Service shutdown: root path changed (renamed or deleted)]
2022-12-15T14:21:52.131Z root ERROR [nsfw-watcher: 1803813] tried to de-allocate a disposed watcher: watcherId=5
2022-12-15T14:21:52.131Z root ERROR [nsfw-watcher: 1803813] tried to de-allocate a disposed watcher: watcherId=0
2022-12-15T14:21:52.132Z root ERROR Error: Unexpected SIGPIPE

[paul-marechal]

Thanks for checking @marcdumais-work! I was mostly curious about the following claim:

The update contains a fix I did Axosoft/nsfw#172 that should fix the issue and (hopefully) also get rid of the frequent PR check failures on ubuntu.

But it seems like Ubuntu CI still fails for some reason then.

[paul-marechal]

I did not notice any regressions, and our previous range would pull the new version on fresh install or upgrade anyway.

[tsmaeder]

Thanks for taking care of this one, folks, as I'm busy with some VS Code API tasks.