Remove unncessary use of RPCProtocol. Fixes #11970

[tsmaeder]

Signed-off-by: Thomas Mäder [email protected]

What it does

Fixes #11970
Removes the unnecessary use of a RPCProtocol instance to communicate with shell processes in terminals.

Contributed on behalf of ST Microelectronics

How to test

Open terminals and make sure they work as usual. Tested on Windows 11. It might be interesting to test this on OSX and Linux. I've made sure performance is not significantly affected for large, fast output. For example, you can output the contents of large files in the terminal.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[paul-marechal]

LGTM otherwise.

[paul-marechal]

The code makes sense to me, and terminals on Windows still work.

[vince-fugnitto]

I believe this change may be resulting in our CI failing:

PR:

Master:

All subsequent builds are now failing due to a task test:

@theia/task:   1 failing
@theia/task:   1) Task server / back-end
@theia/task:        task running in terminal - expected data is received from the terminal ws server:
@theia/task:      Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/theia/theia/packages/task/lib/node/task-server.slow-spec.js)
@theia/task:       at listOnTimeout (node:internal/timers:559:17)
@theia/task:       at processTimers (node:internal/timers:502:7)

[vince-fugnitto]

@tsmaeder do you have time to investigate a fix for the test, else we may need to revert the changes for the time being.

[paul-marechal]

CI failure fixed by #12054.