Explorer: added styling for nodes at root #11967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I believe the changes would be better suited for file-tree-widget.tsx or the explorer directly as to not affect the depth padding for all trees. For example, the search-in-workspace tree is affected by the change when it shouldn't be.
EstFoisy
force-pushed
the
ef/11896
branch
4 times, most recently
from
3ce163e to
91ea2a5
Compare
of workspace Added a tabbing for the child nodes of a root, to have a visual difference and avoid confusion
vince-fugnitto
added
navigator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #11896.
The pull-request updates the rendering of nodes in
FileTreeWidgetby including additional depth padding to help differentiate nodes from the top-level root.How to test
FileTreeWidgetor extensions of the tree work correctlyVideos
Issue.11896.-before.change.mp4
Issue.11896.-.after.change.mp4
Review checklist
Reminder for reviewers