-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
electron: remove disallowReloadKeybinding
#11099
Labels
beginners
issues that are perfect for beginners
good first issue
good first issues for new contributors
Comments
vince-fugnitto
added
beginners
issues that are perfect for beginners
good first issue
good first issues for new contributors
labels
May 3, 2022
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this issue
May 18, 2022
Ref: eclipse-theia/theia#11099 Signed-off-by: Akos Kitta <[email protected]>
ShehanAT
added a commit
to ShehanAT/theia
that referenced
this issue
May 18, 2022
…ation-package/src/application-props.ts; fixes Issue eclipse-theia#11099; Signed-off by Shehan Atukorala<[email protected]>
ShehanAT
added a commit
to ShehanAT/theia
that referenced
this issue
May 18, 2022
…ation-package/src/application-props.ts; fixes Issue eclipse-theia#11099; Signed-off by Shehan Atukorala<[email protected]>
1 task
ShehanAT
added a commit
to ShehanAT/theia
that referenced
this issue
May 19, 2022
…ation-package/src/application-props.ts; fixes Issue eclipse-theia#11099; Signed-off by Shehan Atukorala<[email protected]>
ShehanAT
added a commit
to ShehanAT/theia
that referenced
this issue
May 19, 2022
…ation-package/src/application-props.ts; fixes Issue eclipse-theia#11099; Signed-off by Shehan Atukorala<[email protected]>
ShehanAT
added a commit
to ShehanAT/theia
that referenced
this issue
May 19, 2022
…cation-package/src/application-props.ts; fixes Issue eclipse-theia#11099; Signed-off by Sean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beginners
issues that are perfect for beginners
good first issue
good first issues for new contributors
Feature Description:
The application configuration option
disallowReloadKeybinding
is no longer used, and can be deprecated/removed:theia/dev-packages/application-package/src/application-props.ts
Lines 40 to 47 in 08722fa
It is currently only used in a test, where i can be safely removed:
theia/packages/core/src/browser/frontend-application-config-provider.spec.ts
Lines 33 to 48 in 08722fa
Related Info:
The text was updated successfully, but these errors were encountered: