Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentation: update yarn prerequisites #9724

Closed
vince-fugnitto opened this issue Jul 13, 2021 · 4 comments · Fixed by #9726
Closed

documentation: update yarn prerequisites #9724

vince-fugnitto opened this issue Jul 13, 2021 · 4 comments · Fixed by #9726
Labels
documentation issues related to documentation good first issue good first issues for new contributors help wanted issues meant to be picked up, require help

Comments

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Jul 13, 2021 •
edited
Loading

Feature Description:

We should update the prerequisites documentation to refer to the valid yarn ranges that the framework supports.

The following should be updated from:

 - [Yarn package manager](https://yarnpkg.com/en/docs/install) v1.7.0

to

 - [Yarn package manager](https://yarnpkg.com/en/docs/install)  `>= 1.7.0` **AND** `< 2.x.x`.

We should also update the following:

theia/package.json

Line 6 in 5284996

"yarn": "1.0.x || >=1.2.1",

Note: once #7062 is supported we can update the range.
@vince-fugnitto vince-fugnitto added help wanted issues meant to be picked up, require help good first issue good first issues for new contributors documentation issues related to documentation labels Jul 13, 2021
@RhnSharma
Copy link
Contributor

I would like to take this one.

@vince-fugnitto
Copy link
Member Author

I would like to take this one.

@RhnSharma please go ahead :)

@RhnSharma
Copy link
Contributor

@vince-cognito Do I have to wait for the #7062 to complete to make a pull request?

@vince-fugnitto
Copy link
Member Author

@RhnSharma no, the version range does not include 2.x.x. Only after #7062 would we update the prerequisite again to support it. Please also see the update to the engines.yarn version as referenced in the issue.

@RhnSharma RhnSharma mentioned this issue Jul 13, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation issues related to documentation good first issue good first issues for new contributors help wanted issues meant to be picked up, require help
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: update yarn prerequisites RhnSharma/theia
2 participants
@RhnSharma @vince-fugnitto