Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preferences: toggling 'auto-save' should update user settings #9152

Closed
vince-fugnitto opened this issue Mar 4, 2021 · 6 comments · Fixed by #9178
Closed

preferences: toggling 'auto-save' should update user settings #9152

vince-fugnitto opened this issue Mar 4, 2021 · 6 comments · Fixed by #9178
Assignees
Labels
bug bugs found in the application editor issues related to the editor

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

The framework incorrectly updates the editor.autoSave preference when toggled (through the menu or command), by updating the value in the workspace scope rather than user. We should align the behavior to use the user scope by default similarly to vscode.

autoSave.mp4

Steps to Reproduce:

  1. remove any custom preferences from the user home (for test purposes - ex: rm -rf ~/.theia).
  2. create a temporary folder with a single file (no .theia should be present).
  3. toggle the autoSave command.
  4. notice that a .theia folder is created in the workspace with the setting.
@vince-fugnitto vince-fugnitto added bug bugs found in the application editor issues related to the editor labels Mar 4, 2021
@AbhiSahane0
Copy link

This issue is still open.

@AbhiSahane0
Copy link

Can I go a head to work on it

@vince-fugnitto
Copy link
Member Author

Can I go a head to work on it

@AbhiSahane0 unfortunately I do not believe it is a straighforward issue for beginners to pick up, we will require investigation, debugging and in the end discussions on how to fix the preferences-system (which is core to the framework) in order to achieve a proper solution rather than a patch fix.

@AbhiSahane0
Copy link

Okk , Sir

@colin-grant-work colin-grant-work self-assigned this Mar 9, 2021
@colin-grant-work
Copy link
Contributor

I'll pick this up, since I'm pretty familiar with the workings of the preference system.

@kittaakos
Copy link
Contributor

kittaakos commented Mar 11, 2021

The framework incorrectly updates the editor.autoSave preference when toggled (through the menu or command), by updating the value in the workspace scope rather than user. We should align the behavior to use the user scope by default similarly to vscode.

I am not sure if this is a bug. I also prefer the VS Code UX, (save this config with a user scope) but you cannot just change the runtime behavior that downstreams have been using for years now. What about adjusting it for electron? Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application editor issues related to the editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants