Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not have multiple plugins inside the plugins folder #9064

Closed
pchuong opened this issue Feb 12, 2021 · 3 comments
Closed

Can not have multiple plugins inside the plugins folder #9064

pchuong opened this issue Feb 12, 2021 · 3 comments
Labels
plug-in system issues related to the plug-in system 🤔 needs more info issues that require more info from the author

Comments

@pchuong
Copy link
Contributor

pchuong commented Feb 12, 2021

Bug Description:

Can not have more than one frontend (maybe backend too) non VS plugins inside the plugins folder. I have tested dropping multiple of these example plugins, https://github.com/eclipse/che-theia-samples/tree/master/samples, as well as my own plugin into the plugins folder and only one will be registered.

After debugging the issue, I have found the root cause. The file packages/plugin-ext/src/hosted/browser/hosted-plugin.ts, line 361, const dynamicContributions = hostContributions.get(plugin.host) || []; should be const dynamicContributions = hostContributions.get(host).

Steps to Reproduce:

  1. Build and drop the samples plugins from the link above
  2. Can't open more than one sample plugin

Additional Information

  • Operating System: Ubuntu
  • Theia Version: 1.9
@vince-fugnitto
Copy link
Member

@pchuong thank you for the issue, to clarify are you attempting to consume multiple plugins in the plugin folder on startup (like we do for vscode builitns), or are you trying to launch hosted-plugins? If its the later, I think that only one plugin can be launched at a time as a hosted-plugin.

Can't open more than one sample plugin

The wording here is what confused me, by "open" what do you mean?

@vince-fugnitto vince-fugnitto added 🤔 needs more info issues that require more info from the author plug-in system issues related to the plug-in system labels Feb 12, 2021
@pchuong
Copy link
Contributor Author

pchuong commented Feb 12, 2021

@vince-fugnitto, I have multiple hosted-plugins in the plugins folder. Such as the webview-sample-plugin and my own plugin. Both of these plugin registered for commands. But if I have two both of these plugins in the plugins folder, only one of the plugin is available when I try to run the command using ctrl+shift+p. As soon as I removed either one of this plugin, than the one remaining is available in the list of command.

@vince-fugnitto
Copy link
Member

Closing in favor of #9901 which includes additional information, and is referenced by a pull-request.
Thank you for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system 🤔 needs more info issues that require more info from the author
Projects
None yet
Development

No branches or pull requests

2 participants