Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Debug main menu according to VS Code #8603

Closed
azatsarynnyy opened this issue Oct 7, 2020 · 13 comments · Fixed by #8653
Closed

Rename Debug main menu according to VS Code #8603

azatsarynnyy opened this issue Oct 7, 2020 · 13 comments · Fixed by #8653
Assignees
Labels
good first issue good first issues for new contributors help wanted issues meant to be picked up, require help menus issues related to the menu Team: Che-Editors issues regarding the che-editors team ui/ux issues related to user interface / user experience
Milestone

Comments

@azatsarynnyy
Copy link
Member

Feature Description:

In VS Code, Debug menu has been renamed to Run
image

In Theia, we still have Debug
image

It should be renamed according to VS Code.

@azatsarynnyy azatsarynnyy added ui/ux issues related to user interface / user experience menus issues related to the menu labels Oct 7, 2020
@vince-fugnitto vince-fugnitto added good first issue good first issues for new contributors help wanted issues meant to be picked up, require help labels Oct 7, 2020
@dhairyanadapara
Copy link

Hey @vince-fugnitto, I would love to help. From the description what I understood is the change is to update the menu name from Debug to Go.

@azatsarynnyy
Copy link
Member Author

Hello @dhairyanadapara!
Debug menu has to be renamed to Run.

@dhairyanadapara
Copy link

@azatsarynnyy My bad :|. I got wrong mapping in both menu while writing the comment. Thanks for correction. I will raise the PR once the changes are done. thanks :)

@dhairyanadapara
Copy link

menus.registerSubmenu(DebugMenus.DEBUG, 'Debug');

@azatsarynnyy I found the change requied for updating the menu name. I changed the name to Run and ran npm run start but the change is not showing in the browser. Can you please help me with the problem?

@azatsarynnyy
Copy link
Member Author

@dhairyanadapara have you rebuilt Theia with your changes with yarn command?
See https://github.com/eclipse-theia/theia/blob/master/doc/Developing.md#quick-start

@azatsarynnyy
Copy link
Member Author

Hello @dhairyanadapara,
how thing are going with renaming the menu? Can you the results after rebuilding it with yarn command?
Do you need any help?

@dhairyanadapara
Copy link

Hey @azatsarynnyy, sorry for the delay. I tried with the yarn command but still the change is not shown. I'm using wsl(ubuntu) for development because in windows I'm getting some issue while running yarn for installing dependencies. Do you think this issue is coming due to wsl?

@dhairyanadapara
Copy link

dhairyanadapara commented Oct 20, 2020

Can you please confirm that the change I suggested is correct?

Also, one other issue I found is that if there are any other server running on same port(3000) then the theia overrides the other server. It would be better to run the server on other port like(3001) if some service is already running on 3000. (this issue might be coming due to wsl)

@azatsarynnyy
Copy link
Member Author

Hey @azatsarynnyy, sorry for the delay. I tried with the yarn command but still the change is not shown. I'm using wsl(ubuntu) for development because in windows I'm getting some issue while running yarn for installing dependencies. Do you think this issue is coming due to wsl?

I think it might be related to a browser's cache. Try to reload the page in incognito mode. Or clean-up the cache. If you're using Chrome, try Shift+F5.

@azatsarynnyy
Copy link
Member Author

Can you please confirm that the change I suggested is correct?

Also, one other issue I found is that if there are any other server running on same port(3000) then the theia overrides the other server. It would be better to run the server on other port like(3001) if some service is already running on 3000. (this issue might be coming due to wsl)

@dhairyanadapara 3000 is a default port. It can be specified through the command line arg, e.g. yarn start -p 3001

@azatsarynnyy
Copy link
Member Author

@dhairyanadapara please, let me know if you still have your changes not visible in Theia.
I will provide a PR then.

@dhairyanadapara
Copy link

dhairyanadapara commented Oct 20, 2020

@azatsarynnyy I just followed the instructions you gave, but still no success. You can raise the PR. Thanks :)

@azatsarynnyy azatsarynnyy added this to the 1.7.0 milestone Oct 20, 2020
@azatsarynnyy azatsarynnyy added the Team: Che-Editors issues regarding the che-editors team label Oct 20, 2020
@azatsarynnyy
Copy link
Member Author

azatsarynnyy commented Oct 20, 2020

@azatsarynnyy I just followed the instructions you gave, but still no success. You can raise the PR. Thanks :)

No problem. BTW, @dhairyanadapara you can pick another good first issue from good first issue good first issues for new contributors 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue good first issues for new contributors help wanted issues meant to be picked up, require help menus issues related to the menu Team: Che-Editors issues regarding the che-editors team ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants