Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No indication for deprecated variables #8552

Closed
EstherPerelman opened this issue Sep 23, 2020 · 1 comment · Fixed by #8553
Closed

No indication for deprecated variables #8552

EstherPerelman opened this issue Sep 23, 2020 · 1 comment · Fixed by #8553
Labels
editor issues related to the editor help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility

Comments

@EstherPerelman
Copy link
Contributor

When providing code completion result with deprecated: true property there is no indication in the UI - deprecated value should appear with strike-through.

Bug Description:

lsp-sample plugin.zip contains the vsix file lsp-sample-1.0.0.vsix

Steps to Reproduce:

  1. Deploy vscode extension lsp-sample-1.0.0.vsix
  2. Create empty text file
  3. Try to do code completion.

There's no indication for the deprecated one:
no-indication

While on VSCode it appears with strikethrough:
indication

Additional Information

  • Operating System: Windows
  • Theia Version: Master
@EstherPerelman EstherPerelman mentioned this issue Sep 23, 2020
Merged
1 task
@vince-fugnitto
Copy link
Member

Related VS Code changes.

@vince-fugnitto vince-fugnitto added editor issues related to the editor help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility labels Sep 23, 2020
@vince-fugnitto vince-fugnitto mentioned this issue Sep 23, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editor issues related to the editor help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

plugin: support 'deprecated' strikethrough eclipse-theia/theia
2 participants
@vince-fugnitto @EstherPerelman