Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode git built-in extension (1.47.3) does not work #8318

Closed
akosyakov opened this issue Aug 6, 2020 · 9 comments
Closed

vscode git built-in extension (1.47.3) does not work #8318

akosyakov opened this issue Aug 6, 2020 · 9 comments
Labels
bug bugs found in the application builtins Issues related to VS Code builtin extensions git issues related to git help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

Screenshot 2020-08-06 at 10 51 58

@akosyakov akosyakov added bug bugs found in the application help wanted issues meant to be picked up, require help git issues related to git vscode issues related to VSCode compatibility builtins Issues related to VS Code builtin extensions labels Aug 6, 2020
@amiramw
Copy link
Member

amiramw commented Sep 13, 2020

@akosyakov we are interested in adopting git pane capabilities from vscode.
Do I understand correctly that this issue is the same?
We noticed their pane has sub menus, is this supported by theia?
Is this the git builtin extension used in this scenario?
Does this task involve disabling existing git pane?

@amiramw
Copy link
Member

amiramw commented Oct 12, 2020

After #8523, when running with git builtin version 1.50.0 the error is different:
image

@benoitf
Copy link
Contributor

benoitf commented Oct 12, 2020

Try 1.49.3

@ashwanth1109
Copy link

@benoitf , I have a similar issue but with a different error message.

Activating extension 'Git (built-in)' failed: Class extends value undefined is not a constructor or null

I initially installed git 1.51.1 and faced this issue. So I tried downloading 1.49.3 and installing it, but faced the same issue

@benoitf
Copy link
Contributor

benoitf commented Nov 16, 2020

we're using "vscode-git": "https://open-vsx.org/api/vscode/git/1.49.3/file/vscode.git-1.49.3.vsix" in che-theia and git plug-in is activating fine

@ashwanth1109
Copy link

Thanks for responding.
Hmm, I'm not sure why I was having this issue then. Anyway, I found a workaround to do my stuff without using the vscode-git api.

@tomer-epstein
Copy link
Contributor

It works for us with 1.49.3.
In version 1.5x it shows error.

@vince-fugnitto
Copy link
Member

It works for us with 1.49.3.
In version 1.5x it shows error.

@tomer-epstein likely fixed with the following pull-requests:

@vince-fugnitto
Copy link
Member

Closing the issue as the git plugin (version 1.52.1 is the latest to be confirmed to work).
If there are additional issue please don't hesitate to comment on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application builtins Issues related to VS Code builtin extensions git issues related to git help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

6 participants